UWNetworksLab / colony

Apache License 2.0
5 stars 1 forks source link

openvpn remote controller plugin #19

Closed ryscheng closed 8 years ago

ryscheng commented 8 years ago

Review on Reviewable

jpevarnek commented 8 years ago

Reviewed 8 of 8 files at r1. Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.


client/plugin-src/cordova-plugin-openvpn/openvpn.js, line 4 [r1] (raw file): Is this used for something?


client/plugin-src/cordova-plugin-openvpn/src/android/OpenVPN.java, line 42 [r1] (raw file): Delete this line maybe?


client/plugin-src/cordova-plugin-openvpn/src/android/OpenVPN.java, line 126 [r1] (raw file): Was this just from the boilerplate or is it actually used?


Comments from the review on Reviewable.io