search

UWNetworksLab / uProxy-p2p

Internet without borders
https://www.uproxy.org/
Apache License 2.0
865 stars 180 forks source link

we are weirding english #1654

Closed trevj closed 9 years ago

trevj commented 9 years ago

When sharing fails and the user is behind a full cone NAT, our grammar is poor:

It looks like you are on a FullCone, which is unlikely interfering with your ability to connect to friends.

This happens when "unlikely" is inserted into the __natImpact__ placeholder in the analysisResult message: https://github.com/uProxy/uproxy/blob/1bb0b1b4c1b6d90669b3bc1a9e6b3f308af9aa15/src/generic_ui/locales/en/messages.json#L526

Screenshot attached. likely

trevj commented 9 years ago

Also, what is a FullCone? The term is "full-cone NAT": https://en.wikipedia.org/wiki/Network_address_translation#Methods_of_translation

salomegeo commented 9 years ago

What is unableToShare?

On Wed, Jun 17, 2015 at 3:52 PM, trevj notifications@github.com wrote:

Also, what is a FullCone? The term is "full-cone NAT":

https://en.wikipedia.org/wiki/Network_address_translation#Methods_of_translation

— Reply to this email directly or view it on GitHub https://github.com/uProxy/uproxy/issues/1654#issuecomment-112927142.

trevj commented 9 years ago

Oh yeah, that too :-)

lucyhe commented 9 years ago

my mistake! anyway, fixed: https://github.com/uProxy/uproxy/pull/1657 thanks for filing!