search

UWNetworksLab / uProxy-p2p

Internet without borders
https://www.uproxy.org/
Apache License 2.0
866 stars 180 forks source link

fix socks session bookkeeping when there are concurrent sessions + legacy client support from #2858 #2859

Closed jab closed 7 years ago

jab commented 7 years ago

screen shot 2016-12-16 at 17 14 39

This change is Reviewable

jab commented 7 years ago

Hey @trevj, I merged your backwards compatibility changes into this branch, resolved the resulting conflicts, and corrected the socks session reference bookkeeping in a way that works with the backwards compatibility changes. If these changes are merged, GitHub should automatically mark your #2858 as merged since this branch includes those commits.

jab commented 7 years ago

updated PR title to be more accurate

jab commented 7 years ago

I tested pointing Firefox at this, browsing heavy pages, streaming video, and downloading a 100+MB file, and couldn't tell I was using a proxy. Do you get similarly good performance and stability?

This version should also work with legacy clients as well as the version in #2858, but worth testing just to make sure I didn't screw anything up when I merged/ported. I'll see if I can figure out how to get that streamlined run_pair.sh testing workflow you showed me set up!

jab commented 7 years ago

First attempt: tried run_pair.sh node-stable node-stable and appears to be stuck at "Waiting for getter to come up":

screen shot 2016-12-19 at 12 30 56

I tried with "chrome-stable firefox-stable" in case it was something wrong with my node image, and the same thing happened. I assume it shouldn't take this long for the getter to come up, and something's actually going wrong in some hidden way?

trevj commented 7 years ago

Wonderful, thanks for finding the fix! 👍

Regarding run_pair.sh, try the -p switch:

run_pair.sh -p node-stable node-stable
trevj commented 7 years ago

Excellent! I just ran this against a legacy Firefox-based server and it works just fine: fast, and I wasn't able to break it.

:+1:

trevj commented 7 years ago

Ah I see some lint errors to address - then we'll be good to go.

jab commented 7 years ago

Thanks so much for the help testing, @trevj, so glad to hear it worked for you with a legacy Firefox peer! I've fixed the lint issues as discussed, so just merged. Psyched to get this in, uncertain future notwithstanding!