search

UWNetworksLab / uProxy-p2p

Internet without borders
https://www.uproxy.org/
Apache License 2.0
862 stars 181 forks source link

use native travis support for yarn #2860

Closed trevj closed 7 years ago

trevj commented 7 years ago

This change is Reviewable

trevj commented 7 years ago

Based on: https://blog.travis-ci.com/2016-11-21-travis-ci-now-supports-yarn

Thanks for the pointer, @jab!

jab commented 7 years ago

Nice @trevj! 👍 👍 👍

jab commented 7 years ago

Would we not want to cache node_modules too, as mentioned in the blog post?

cache:
  yarn: true
  directories:
    - node_modules
jab commented 7 years ago

@fortuna Won't it still help for the requirements that stay the same between runs? That's how it works with a pip (Python installer) directory I have Travis set up to cache in one of my projects, and is also what that blog post @trevj linked to above demonstrates doing, no?

trevj commented 7 years ago

I just tried the blog post way with node_modules explicitly called out but honestly it's hard to see a difference - I suspect @fortuna is right to say that since yarn does its own caching and is fast that caching node_modules explicitly probably doesn't make much sense.

I think I'll revert to the simple cache: yarn.