search

UWNetworksLab / uProxy-p2p

Internet without borders
https://www.uproxy.org/
Apache License 2.0
862 stars 181 forks source link

move to alpine for ssh docker image, remove some unused features #2868

Closed trevj closed 7 years ago

trevj commented 7 years ago

Some pre-Christmas mucking around I didn't want to lose...this reduces the size of the uproxy/sshd image from 281MB to 53MB. I also took the opportunity to remove some unused features, e.g. -i.

This change is Reviewable

dborkan commented 7 years ago

👍

dborkan commented 7 years ago

Also with the recent changes to uproxy and uproxy-website, we are always going to be passing in the -k (public key for ssh) argument. Would it be possible to also remove the code that generates a new invite? Then issue_invite.sh would just setup the ssh authorized_keys and permissions?

trevj commented 7 years ago

Yeah, hadn't thought of that - I'd like to keep command-line/manual installs easy if at all possible though, for our own development if nothing else, what do you think?

dborkan commented 7 years ago

I think it's fine for now, but the invite generation in issue_invite.sh has some potential to diverge, for example it's already missing the new cloud server name field. Right now we should just default to the IP if that's missing, but I could imagine them getting more out of sync going forward

On Jan 6, 2017 17:38, "trevj" notifications@github.com wrote:

Yeah, hadn't thought of that - I'd like to keep command-line/manual installs easy if at all possible though, for our own development if nothing else, what do you think?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/uProxy/uproxy/pull/2868#issuecomment-271029801, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMYYxmJDeAfHYzQ9pZ9E32sUg6yN32Bks5rPsJ5gaJpZM4LdDgW .

trevj commented 7 years ago

Yes, big potential to diverge which is why I'm asking on https://github.com/uProxy/uproxy/pull/2853 :-)

One update here: the version of OpenSSH included with Alpine 3.5 includes the restrict option which reduces the length of our authorized_keys lines a lot.