too many steps required for npm run benchmark

UWNetworksLab / uProxy-p2p

Internet without borders

https://www.uproxy.org/

Apache License 2.0

865 stars 182 forks source link

too many steps required for npm run benchmark #535

Closed iislucas closed 9 years ago

iislucas commented 10 years ago

Trying to run the benchmarking results in socks server giving an error net::ERR_CONNECTION_REFUSED
wup should be added to package.json as a dev dependency
Call to start wup and benchmarking should be made into a grunt task
Error handling in case you forgot to start your webserver should be added to benchmarking

@mollyling sound right to you?

trevj commented 9 years ago

Not sure what you want to do here @mollyling but it seems like this is best assigned to you.

mollyling commented 9 years ago

Yeah, sure.

iislucas commented 9 years ago

@mollyling ping?

mollyling commented 9 years ago

So do we have a way of bringing up the simple-socks-chromeapp automatically?

iislucas commented 9 years ago

The networking benchmark tests are the way to do this. see: https://github.com/uProxy/uproxy-networking/tree/dev-requireify/src/integration-tests/socks-echo

(note: dev-requireify branch)

@bemasc knows about how these tests work pretty well also if you want in person discussion this week :)

iislucas commented 9 years ago

@mollyling update?

mollyling commented 9 years ago

socks-echo is a jasmine-hosted test, vs the existing benchmark, which is a command-line test. I spent some time in socks-echo, adding a remote-close test, but didn't see how to report statistics (unless we were just looking for a threshold) in jasmine.

Unless you meant to have a grunt task have to make launch our simple-socks-chromeapp and then call the benchmark around it? I didn't consider that until I wrote this response....

trevj commented 9 years ago

Splitting into two isses: https://github.com/uProxy/uproxy/issues/1504