Extract Churn's NAT hole-punching into a separate subcomponent with its own interface

matthild commented 9 years ago

This refactoring will:

Simplify the Churn code by disentangling unrelated concerns (how the NAT hole is punched vs. how the churning occurs).
Facilitate upcoming changes, such as #567 and, longer-term, implementing our own ICE-like mechanism.

matthild commented 9 years ago

Progress on this issue has been blocked pending clarity about the future of "Thin ICE". Ben mentioned that it's not yet clear that Thin ICE will actually work (see, for example, https://github.com/uProxy/uproxy/issues/608).

If Thin ICE is here to stay, then the proposed refactoring no longer applies (no separate NAT hole-punching step exists in Thin ICE). Instead, we could still separate out initial candidate gathering from establishing the obfuscated connection. This change is different but thematically similar.

If Thin ICE goes away, then the proposed refactoring could proceed, but only after Thin ICE is removed from the Churn code.

Please ping this issue when there is a decision.

trevj commented 9 years ago

So, Thin ICE has been in place for some time. It's pretty tangled in with the churn code so this would still be nice...just beware that "Holographic ICE" will soon change all this code again, sorry :-)

UWNetworksLab / uProxy-p2p

Extract Churn's NAT hole-punching into a separate subcomponent with its own interface #585