search

UWPCE-PythonCert / PythonCertDevel

Development Repo for the Certificate Program
https://uwpce-pythoncert.github.io/PythonCertDevel/index.html
Other
7 stars 15 forks source link

Mailroom review #157

Closed PythonCHB closed 5 years ago

PythonCHB commented 5 years ago

Starting a PR for the mailroom review

natasha-aleksandrova commented 5 years ago

@UWEditor your edits are here, part of this PR

UWEditor commented 5 years ago

Thanks. I'm still deeply confused, but am glad I didn't mess anything up.

KRIS FREEMAN Online Learning Production Specialist UW Continuum College

UW Tower, Box 359491 4333 Brooklyn Ave NE Seattle, WA 98194-9480 kfreeman@uw.edumailto:kfreeman@uw.edu / continuum.uw.eduhttps://www.continuum.uw.edu/ [http://www.washington.edu/brand/files/2014/10/e-sig.gif]

From: Natasha notifications@github.com Sent: Tuesday, August 28, 2018 10:15:22 AM To: UWPCE-PythonCert/PythonCertDevel Cc: Kris Freeman; Mention Subject: Re: [UWPCE-PythonCert/PythonCertDevel] Mailroom review (#157)

@natasha-aleksandrova commented on this pull request.

please see comments.

In source/exercises/mailroom-part1.rsthttps://github.com/UWPCE-PythonCert/PythonCertDevel/pull/157#discussion_r213398563:

@@ -4,14 +4,16 @@ Mailroom Part 1

-Using Python's basic data types and logic for a full program +Use Python's basic data types and logic for a full program + +.. This needs some updating now that we've broken it out into multiple files

can this line be removed plz?

In source/exercises/mailroom-part1.rsthttps://github.com/UWPCE-PythonCert/PythonCertDevel/pull/157#discussion_r213398690:

+.. I changed heading to match title of function.

can you please remove this

In source/exercises/mailroom-part1.rsthttps://github.com/UWPCE-PythonCert/PythonCertDevel/pull/157#discussion_r213398822:

- If the user (you) selects 'Send a Thank You', prompt for a Full Name. + If the user (you) selects 'Send a Thank You,' prompt for a Full Name.

comma should be after ' like before

In source/exercises/mailroom-part1.rsthttps://github.com/UWPCE-PythonCert/PythonCertDevel/pull/157#discussion_r213398918:

    • If the user types 'list', show them a list of the donor names and re-prompt.
    • If the user types 'list,' show them a list of the donor names and re-prompt.

same here, comma should be after '

In source/exercises/mailroom-part1.rsthttps://github.com/UWPCE-PythonCert/PythonCertDevel/pull/157#discussion_r213399085:

  • If the user types a name not in the list, add that name to the data structure and use it.
    • If the user types a name in the list, use it.
      • Once a name has been selected, prompt for a donation amount.
      • Turn the amount into a number; it is OK at this point for the program to crash if someone types a bogus amount.
      • Once an amount has been given, add that amount to the donation history of +* Once a name has been selected, prompt for a donation amount.
      • Input the amount as a number; it is OK at this point for the program to crash if someone types a bogus amount.

Should be "Convert the amount into a number"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/UWPCE-PythonCert/PythonCertDevel/pull/157#pullrequestreview-150226866, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AofHWtIoH9UNFNtDoaOW5MGVnrI51K13ks5uVXqqgaJpZM4WO4QL.

natasha-aleksandrova commented 5 years ago

@UWEditor I see new commits but doesn't look like my comments were addressed.