search

UXARRAY / uxarray

Xarray-styled package for reading and directly operating on unstructured grid datasets following UGRID conventions
https://uxarray.readthedocs.io/
Apache License 2.0
139 stars 30 forks source link

Remapping Notebook #807

Closed aaronzedwick closed 1 week ago

aaronzedwick commented 1 month ago

Closes #805

Overview

Adds a user guide section for remapping. This also updates the remapping functions to use face centers as default instead of nodes and from using kd_tree for cartesian to using ball_tree.

PR Checklist

General

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

aaronzedwick commented 3 weeks ago

I have submitted a few comments under ReviewNB. Let me know if you can see them.

I also in Boulder this week, so I apologize if I'm a little slow on these reviews.

That's understandable! Thanks for taking the time to review, I can't see any comments on ReviewNB though.

philipc2 commented 3 weeks ago

Can you view them here?

https://app.reviewnb.com/UXARRAY/uxarray/blob/zedwick/remapping_notebook/docs/user-guide/remapping.ipynb/

aaronzedwick commented 3 weeks ago

Yes, thank you!

philipc2 commented 2 weeks ago

Link to the user guide section

philipc2 commented 2 weeks ago

Once #819 is merged, we need to update the references to destination_obj to destination_grid

philipc2 commented 2 weeks ago

Can you make sure to clear the output & restart the kernel for the notebook? Looks like some unnecessary outputs and metadata were included in the commit.

aaronzedwick commented 2 weeks ago

Can you make sure to clear the output & restart the kernel for the notebook? Looks like some unnecessary outputs and metadata were included in the commit.

Yeah, sorry about that, I forgot to hit save when I did that right before committing.