Open rytam2 opened 5 days ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
philipc2 commented on 2024-07-08T16:41:20Z ----------------------------------------------------------------
Maybe we could change the title to something that better reflects the content of the notebook?
"Analysis of E3SMv2 Model Output"
View / edit / reply to this conversation on ReviewNB
philipc2 commented on 2024-07-08T16:41:21Z ----------------------------------------------------------------
This workflow example showcases how to use UXarray to analyze the unstructured grid output from the Energy Exascale Earth System Model (E3SM) model directly without needing to perform any regridding operations.
View / edit / reply to this conversation on ReviewNB
philipc2 commented on 2024-07-08T16:41:22Z ----------------------------------------------------------------
Line #22. warnings.filterwarnings("ignore")
We want to have this warning filter be the first thing we execute so that none of the warnings show up.
View / edit / reply to this conversation on ReviewNB
philipc2 commented on 2024-07-08T16:41:23Z ----------------------------------------------------------------
This is great!
View / edit / reply to this conversation on ReviewNB
philipc2 commented on 2024-07-08T16:41:24Z ----------------------------------------------------------------
The latex appears to be broken in the rendered documentation.
You want to use the following syntax instead (for example)
{math}4{\pi}{r^2}
Hi Philip, thanks for the comment! For the syntax, do you mean I'll do the following:
$$ {SWCRE = FSNT-FSNTC} $$
Or do you mean adding {math}
before the SWCRE...FSNTC
equation, and have $$
removed?
Correct, it should look like {math}{SWCRE = FSNT - FSNTC}
View / edit / reply to this conversation on ReviewNB
philipc2 commented on 2024-07-08T16:41:25Z ----------------------------------------------------------------
I do like the idea of having this example of plots in a single row compared to the stacked ones below, but I think for consistency we should keep these plots the same as the ones below.
View / edit / reply to this conversation on ReviewNB
philipc2 commented on 2024-07-08T16:41:25Z ----------------------------------------------------------------
Line #45. * features.opts(fig_size=160)
This applies to the other plots too. Can we try a slightly larger fig_size
.Maybe 250?
Hi Philip, thanks for the comment! For the syntax, do you mean I'll do the following:
$$ {SWCRE = FSNT-FSNTC} $$
Or do you mean adding {math}
before the SWCRE...FSNTC
equation, and have $$
removed?
Closes #822
Overview
Expected Usage
PR Checklist
General
Testing
Documentation
_
) and have been added todocs/internal_api/index.rst
docs/user_api/index.rst
Examples
docs/examples/
folderdocs/examples.rst
toctreedocs/gallery.yml
with appropriate thumbnail photo indocs/_static/thumbnails/