The code to rename UGRID topology names does not use attributes to check names. This bug ignores edge and face coordinates names to rename.
Also, there is a typo in the face coordinates renaming, which will replace names with the wrong variables.
PR Checklist
General
[x] An issue is linked created and linked
[x] Add appropriate labels
[x] Filled out Overview and Expected Usage (if applicable) sections
Testing
[ ] Adequate tests are created if there is new functionality
[ ] Tests cover all possible logical paths in your function
[ ] Tests are not too basic (such as simply calling a function and nothing else)
Documentation
[ ] Docstrings have been added to all new functions
[ ] Docstrings have updated with any function changes
[ ] Internal functions have a preceding underscore (_) and have been added to docs/internal_api/index.rst
[ ] User functions have been added to docs/user_api/index.rst
Examples
[ ] Any new notebook examples added to docs/examples/ folder
[ ] Clear the output of all cells before committing
[ ] New notebook files added to docs/examples.rst toctree
[ ] New notebook files added to new entry in docs/gallery.yml with appropriate thumbnail photo in docs/_static/thumbnails/
Addresses UXARRAY/uxarray#846
Overview
The code to rename UGRID topology names does not use attributes to check names. This bug ignores edge and face coordinates names to rename. Also, there is a typo in the face coordinates renaming, which will replace names with the wrong variables.
PR Checklist
General
Testing
Documentation
_
) and have been added todocs/internal_api/index.rst
docs/user_api/index.rst
Examples
docs/examples/
folderdocs/examples.rst
toctreedocs/gallery.yml
with appropriate thumbnail photo indocs/_static/thumbnails/