Fix UXARRAY/uxarray#862 - Githubissues

UXARRAY / uxarray

Xarray extension for unstructured climate and global weather data analysis and visualization.

https://uxarray.readthedocs.io/

Apache License 2.0

148 stars 31 forks source link

Fix UXARRAY/uxarray#862 #863

Closed kjnam closed 1 month ago

kjnam commented 1 month ago

This commit removes an unnecessary set of parentheses around isel, which creates a tuple, causing an error later in the UxDataArray construction.

Overview

Expected Usage

No change in usage.

PR Checklist

General

[x] An issue is linked created and linked
[x] Add appropriate labels
[x] Filled out Overview and Expected Usage (if applicable) sections

Testing

[ ] Adequate tests are created if there is new functionality
[ ] Tests cover all possible logical paths in your function
[ ] Tests are not too basic (such as simply calling a function and nothing else)

Documentation

[ ] Docstrings have been added to all new functions
[ ] Docstrings have updated with any function changes
[ ] Internal functions have a preceding underscore (_) and have been added to docs/internal_api/index.rst
[ ] User functions have been added to docs/user_api/index.rst

Examples

[ ] Any new notebook examples added to docs/examples/ folder
[ ] Clear the output of all cells before committing
[ ] New notebook files added to docs/examples.rst toctree
[ ] New notebook files added to new entry in docs/gallery.yml with appropriate thumbnail photo in docs/_static/thumbnails/

kjnam commented 1 month ago

@erogluorhan No problem. It seems I am hitting edge cases that are not being tested. Thanks for the great work.