UXDivers / Gorilla-Player-Support

This is the public Gorilla Player support website
http://gorillaplayer.com
115 stars 17 forks source link

General enhacements #41

Open jpbrocca opened 8 years ago

jpbrocca commented 8 years ago

For your convenience I have created this issue to add raw info about suggestions/enhancements.

Thanks in advance!

RonnyRos commented 8 years ago

1) Some stability improvement on the server and client. Seems to happen when u start visual studio and work the server alot by connecting both in VS2015 and Android client.

Make sure the server works on socket timeouts. If you quit your client/server make sure the sockets pick it up and properly shows that the client is disconnected. Make sure the server does not need to be restarted due timeouts.

2) If its possible to really deploy the gorillaplayer without force uninstalling on the devices when switching from mac/win.

It seems like the the gorilla player wont start after you switch from mac/windows to one other then you have to redeploy from the current OS to make it work

3) Vs2015 better menu for gorillla player like stick to xml onto the solution explorer.

Navigating tools->gorilla player->stick to xml/connect etc etc, should be fewer and easier steps with maybe a visual indicators if possible.

4) Often the gorilla player needs to be recompiled and relaunched as it just shuts down (i havent checked log on android why) This is again related to step 2.

5) When gorilla player shines is when you can use 3 devices++ connected to the server and design all realtime. Android s5, nexus7 and Iphone 4s. Problem again is that sometimes the socket stability is somewhat not good enough as it seem to time out and needs to be restarted. A indicator on the server showing whos connected (Device id) would of been helpful.

jpbrocca commented 8 years ago

Thanks @Horrorshow, we will review your great suggestions soon and get back to you.

Thanks again! JP

RonnyRos commented 8 years ago

np! :)

ghost commented 8 years ago

Something I'd like to see is support for AndroidManifest.xml themes; I currently use Theme.Material.Light but in Gorilla Player everything shows up as black and dark gray.

Here's my AndroidManifest.xml:

<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="testing.testapp" android:installLocation="auto">
    <uses-sdk android:minSdkVersion="15" />
    <application android:label="TestApp"
               android:theme="@android:style/Theme.Material.Light">
  </application>
</manifest>
LeoHere commented 8 years ago

Thanks for your feedback @Horrorshow, it is really useful.

Regarding 2), the only way in which Gorilla Player might be tight to the machine it is deployed from is by the Gorilla server name it will look for by default. During Gorilla installation a name is generated for your Gorilla host app. Usually the name is something like "Gorilla on ". If you deploy the player (out of the box) to a device from Machine1 it will automatically try to connect to "Gorilla on Machine1". But you should always be able to connect to other Gorilla host apps.

You can always change the default Gorilla host app a player looks for by changing the name passed to Config class in AppDelegate or MainActivity, in the player solution.

Can you elaborate a bit more in the steps required to reproduce 2)?

RonnyRos commented 8 years ago

LeoHere i havent researched it to the full extent, but the scenario is when i work on xamarin trial (30days) on one machine (a mac) and deploy it do some codework, later switch to a windows machine i have to recompile and rebuild the player on the device or else it just shuts down before starting up. Ill have a look at the log what the error says, might be my development environment. Sorry for the vague feedback.

omanuke commented 8 years ago

I wanna use my own View class as base class which is derived from ContentView or ContentPage, but they doesn't work on Gorilla. Attached it as sample.

Gorilla allows just default classes like ContentView ,ContentPage,TabbedPage,etc? If it so, it's better that Gorilla ignore derived class and treate as ContentView or ContentPage.

CustomeView.txt

omanuke commented 8 years ago

sorry,related issues was written already.

jpbrocca commented 8 years ago

Hi @omanuke...no worries, thanks for your collaboration! :)

RonnyRos commented 8 years ago

Is baseclass supported yet?, or a easy workaround?

ghost commented 8 years ago

44yö On Feb 28, 2016 16:08, "Ronny Rosvold" notifications@github.com wrote:

Is baseclass supported yet?

— Reply to this email directly or view it on GitHub https://github.com/UXDivers/Gorilla-Player-Support-And-Issues/issues/41#issuecomment-189889080 .

0rupp commented 8 years ago

1) Support cross platform images that use ImageResourceExtension (Official Xamarin Forms: Working with Images article) 2) The SampleData.json seems to work for .xaml files located in root folder only. I have my files in a subfolder, and can't figure out how to bind the data from the .json file to them. It seems to work fine moving the .xaml file down to the root folder, starting gorilla and moving it back to the subfolder 3) The Gorilla App (Android, haven't tested iOS), disconnects when the screen goes off. Then when waking the phone I need to tap my server, scroll down (annoying!) and re-connect. Maybe the connection could be left open or a auto-reconnect of the last-opened connection could occur on start-up.

LeoHere commented 8 years ago

Hi @0rupp, Regarding your requests: 1) Ok, got it. 2) This should work in Gorilla as it is. I just updated this wiki page with a more in deep example of how it works. 3) This scroll down issue (yes annoying) is fixed in the next version. We also added an option to avoid the device screen to go off. Gorilla should auto connect by default when discovery mode is used and the server name it is looking for is discovered. If you want to go deeper in diagnosing why it is not auto-connecting in you case please open a separate issue.

Mr-Pearce commented 8 years ago

I would like a "fake Toolbar/Menubar" funktion. I have a MasterDetailApp and in the preview the Menu-bar is missing which leads to stuff eaten up by the IOS "Carrier Time Battery" bar or that stuff is text in text in that area.

How It Looks 2016-09-16_04-16-27-

How It shoud 2016-09-16_04-34-32-

LeoHere commented 8 years ago

@Mr-Pearce did you tried this?

Mr-Pearce commented 8 years ago

@LeoHere FacePalm ... yes now i did. Works perfect!

EricWu91 commented 8 years ago

Hey there. Firstly... awesome tool. It really saved me a lot of time. I'd like to know if there is a way of making Gorilla read the static resources from another, referred library. See if the following structure is clear enough:

Project A (reference) Project B.dll ---> App.cs *---> App.xaml

Project B ---> Page1.xaml ---> Page2.xaml

Pages 1 and 2 contain static resources that are present at App.xaml, but aren't found by Gorilla (presumably) because they are in another dll, and an error is thrown (resource not found). It would be awesome if these resources could be considered.

Thanks in advance!

LeoHere commented 8 years ago

@EricWu91 AFAIK, what you want to do is not possible in XF. Usually Project A would reference project B and the App.xaml would be the XF Application. In this case you will be able to access the resources in the App.xaml from Page1.xaml and Page2.xaml.

EricWu91 commented 8 years ago

Sorry, @LeoHere , I was typing in a hurry and didn't see the actual structure. I updated the comment. It is exactly as you said. The question remains, though. Gorilla doesn't seem to be able to read the resources contained at App.XAML (throws an error).

LeoHere commented 8 years ago

It should. Any chance you can share the app source or generate a test proj where we can reproduce the issue?

EricWu91 commented 8 years ago

Hm, sadly, the codebase is proprietary (and too large) to be shared. :( If there are any logs GP generates, I'll be happy to upload them.

LeoHere commented 8 years ago

Got it. Ok, set Gorilla to log level debug (see this), try to preview the problematic page again and send me those logs to l r o d r i g u e z at u x d i v e r s . c o m

EricWu91 commented 8 years ago

@LeoHere , thanks for the helpfulness. It is really appreciated. Truth be told, it actually doesn't make much sense to work under Gorilla. If Project B (which I call "Base") will only have the .xaml files, if I want to see them in GP, I'll have to go to that specific project and try to visualize them. Thing is, the resources (contained in App.xaml) are, indeed, in another dll it has no sight on. Sorry to waste your time :(

EricWu91 commented 8 years ago

As a sidenote though... I'm seemingly facing issues on loading UXDivers.Gorilla.Common on iOS (Assembly not loaded exception), both in Simulator and Device. Assemblies are referred in the iOS project. Android doesn't have the same behaviour (loads correctly). Are there reported issues?

aubykhan commented 7 years ago

@LeoHere I have modified the Gorilla Player on Android to support Material Design themes. Was looking for a GitHub repo to add a pull request for these changes. Possible? or is it already supported in latest Player?

LeoHere commented 7 years ago

@EricWu91, sorry for the delay, which version of XF are your using? (forcing the assembly to be loaded by doing a typeof<UXDivers.Gorilla.Platform.JsonLoader>())

@aubykhan, no the current android player is not based on AppCompat. We will consider adding it. It is not clear for me if most of XF Android projects are indeed based on AppCompat, any info on that? If that is the case it makes lot of sense to move to AppCompat.

aubykhan commented 7 years ago

@LeoHere I think most of them are indeed using AppCompat now. Even if you create a new project, it's made as AppCompat by default.

I have create a repo for that. It works perfectly and uses LightTheme with DarkActionBar: https://github.com/aubykhan/Gorilla-Player---Material

LeoHere commented 7 years ago

Ok, cool thanks!!

EricWu91 commented 7 years ago

@LeoHere , I'm using 0.9.1.2 (the last stable version in Nuget)

EricWu91 commented 7 years ago

Also, I can confirm @aubykhan in that Xamarin Forms' Android projects are born with a AppCompat Theme.