search

UbayGD / reboottouefi

This is a small Gnome extension that adds the ability to reboot directly to the UEFI.
11 stars 9 forks source link

Weird spaces before text #8

Closed adamvalt closed 1 year ago

adamvalt commented 1 year ago

Screenshot from 2022-12-29 08-57-20(1)

Gnome version 43.2 Saw your comment in the code, maybe they fixed it? Or it is just colliding with some other extension.

UbayGD commented 1 year ago

Hi! I'm testing right now on Fedora 37 with Gnome 43.2 and it works fine. What distro are you using? To test in a virtual machine and see if the same thing happens.

I'm seeing that you also get "hibernate" options. Are they of a another extension?

maeries commented 1 year ago

Same issue here. Manjaro with Gnome 43.2 grafik

UbayGD commented 1 year ago

Ok, I have created a VM with Manjaro and, indeed, the text appears with those extra spaces.

I will investigate why there is that difference between distros, since the Gnome version is the same. I will keep you informed.

adamvalt commented 1 year ago

Yes, manjaro. Thank you.

LucasLelievre commented 1 year ago

Hello, I have the same issue on Fedora 37 with Gnome 43.2. I am able to fix it by changing PopupMenu.PopupImageMenuItem(itemLabel, '') by PopupMenu.PopupMenuItem(itemLabel) in the code (see the "Restart to Windows..." menu item I created).

Screenshot from 2023-01-21 11-44-25

What do you think ?

UbayGD commented 1 year ago

Hello, I have the same issue on Fedora 37 with Gnome 43.2. I am able to fix it by changing PopupMenu.PopupImageMenuItem(itemLabel, '') by PopupMenu.PopupMenuItem(itemLabel) in the code (see the "Restart to Windows..." menu item I created).

Screenshot from 2023-01-21 11-44-25

What do you think ?

It looks really good. I would never have thought to check if I was using the wrong MenuItem hahaha.

If you want you can make a pull request with that change.

LucasLelievre commented 1 year ago

If you want you can make a pull request with that change.

I will then thank you.

UbayGD commented 1 year ago

A new extension update is on the way. If you have installed it from Gnome Extensions you should get the notification at some point.

I will close the issue as it should be all fixed. Thanks to all of you!