Ube-Dev / Voluntree

A volunteer management system that matches willing volunteers with nonprofits, and other organizations.
https://ube-dev.github.io/
MIT License
2 stars 0 forks source link

Review: AdminOrganizationModeration.jsx and AdminHome.jsx #183

Closed thomasarivera closed 5 months ago

thomasarivera commented 5 months ago

Overview

The focus for this code review will be centered around the AdminOrganizationModeration.jsx page and AdminHome.jsx component.
Please pay attention too:

Review Branch

review-183

Files to review

Checklists

Due date

Monday, April 29th @ 11pm

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

ryanseng03 commented 5 months ago

AdminOrganizationModeration.jsx

AdminHome.jsx

thomasarivera commented 5 months ago

AdminOrganizationModeration.jsx

TA-02: Each form has an acceptance test. L109: eslint error - add alt to Image

AdminHome.jsx

TA-02: L31 - Each form has an acceptance test.

Jchen20-1 commented 5 months ago

AdminOrganizationModeration.jsx

L89: component ID doesn't exist (ORGANIZATION_SEARCHBAR)

AdminHome.jsx

Looks good

aldenparoni commented 5 months ago

AdminOrganizationModeration.jsx

AdminHome.jsx

jianleliu commented 5 months ago

AdminOrganizationModeration.jsx

looks good

AdminHome.jsx

looks good

hokwaichan commented 5 months ago

AdminOrganizationModeration L80 component id does not exit Can add comments

AdminHome.jsx Looks good

willjsimmons commented 5 months ago

AdminOrganizationModeration

Other than the aforementioned! it looks good

AdminHome.jsx

Looks good

aldenparoni commented 5 months ago

Outcome of review meeting

Work done in this branch:

New issue: