disable worldedit_brush mod instead of throwing error

[codexp]

how about this fix?

Mod still runs even if worldedit_brush is disabled.

[sfan5]

I'd prefer a more explicit message, not everyone looks at the console output.

[codexp]

Do you mean output in chat for player? Or do you mean more detailed message as in error message that has been commented out (but server log)?

You could suggest full message, too. Maybe the commented out error should be removed completely?

[codexp]

accidentally hit "close and comment" button, sry!

[sfan5]

Do you mean output in chat for player?

Yes, that would be better. Alternatively you could log an error, that will appear as red text in chat too (in singleplayer).

[codexp]

Actually this would disturb me very much, seeing a red error message in the chat every time I connect to the server. And I think this is how most players would feel too. Even worse, if they don't even know what worldedit is, they will be confused by that (sure you can also check privs before spitting it out, but won't it be overkill?).

I think it's enough to have it in the server log, maybe on the main formspec too? I recently saw how to format colorful text labels on the formspec, maybe we should give it a try?

[sfan5]

Actually this would disturb me very much, seeing a red error message in the chat every time I connect to the server.

That's the point. You're supposed to disable worldedit_brush if it's not functional, hence why it's an error() currently.

[codexp]

that was my question. No, it's a change proposal to make it a server side log entry only (and not crash the server).

[sfan5]

As I said, a log message with "error" severity would be okay.

[codexp]

Sorry! English isn't my native language, I probably misunderstood some things. But now it should be close to what you said?

[sfan5]

Yeah, this is very close.

[codexp]

This message will be misleading for server admins, but not a big deal.