Uberi / Minetest-WorldEdit

The ultimate in-game world editing tool for Minetest! Tons of functionality to help with building, fixing, and more.
https://forum.minetest.net/viewtopic.php?f=11&t=572
GNU Affero General Public License v3.0
162 stars 81 forks source link

//set ignores metadata and param2 #181

Open HybridDog opened 5 years ago

HybridDog commented 5 years ago

I think that worldedit.set currently completely ignores the metadata and param2 (and the usually volatile param1) values. This leads to the problem that e.g. when the player execute /set stone with a chest in the selected area, the chest inventory is still there afterwards, in the stone. With the /replace command, not changing the param2 may sometimes be intended, e.g. when replacing stair nodes. When using //set default:tree on the stair nodes, the trees retain the stairs rotation, which is usually not desired. http://github.com/Uberi/Minetest-WorldEdit/blob/b2e086f9ec07ea0cdf4b7af81758cf544240a936/worldedit/manipulations.lua#L16

sfan5 commented 1 year ago

The interesting question is, in which case should //set reset param2:

The best way here is probably to add new command(s) that really get rid of everything in the area, which users can then use if they intend to. But then that doesn't work with //replace, so maybe a flag?