Closed ShadowNinja closed 9 years ago
Bump.
Bump. @Uberi & @sfan5
We'll need to rebase this, of course, but the changes look really good overall! Is it possible to include an HTML copy of the LuaDoc output with the downloads, so users don't have to install it?
@Uberi Of course, but not with GitHub's auto-archives (or at least, not without polluting the commit history with doc re-builds and including a built version in the repo). You'll have to make custom archives. GitHub will host them for you if you make a release though.
You can set up a Travis script that auto-updates the docs in a GitHub pages repo too.
Of course, you can also host the docs on your own site (with a script to auto-update them, probably fairly trivially implementable in Python with GitHub's commit hook system, a builtin simple HTTP server library, and the subprocess
library) and link to them.
Rebased.
@Uberi So... good to merge now?
Oh, for sure - everything looks good to me. In the future, feel free to merge changes after code review!
Non-stylistic changes:
ldoc .
. (see screenshots below)clear_objects
area size calculation.clear_objects
removing player objects.clear_objects
in yet another way)swap_node
.hide
from hiding air.we-replaceinverse
not using normalized node names.*~
for now).Stylistic changes:
x = function
tofunction x
.sort_pos
intocommon.lua
, which is a required module (it was already copied about three times, and it needed to be copied again for a module that was missing it, there's not really a reason to exclude it too, so requiring it is O.K.).minetest
. (Anything that used a core function in a speed-critical area localized the specific function needed, so the speedup was minimal)worldedit = worldedit or {}
from modules. (init.lua
defines this)replace
.error()
s on on invalid axes.wip
toTODO
.clearobjects
toclear_objects
.hollow_{sphere,dome,cylinder}
and replace them with a hollow parameter to each function.Chat Commands.md
toChatCommands.md
(LDoc has an issue with the space).Generated documentation (this is a little outdated, but it's mostly the same): Note: Due to the number of changes it's hard to thoroughly test this, so I wouldn't be surprised if this introduces a few bugs.