search

Uberi / Minetest-WorldEdit

The ultimate in-game world editing tool for Minetest! Tons of functionality to help with building, fixing, and more.
https://forum.minetest.net/viewtopic.php?f=11&t=572
GNU Affero General Public License v3.0
162 stars 81 forks source link

Add //deleteblocks command #71

Closed est31 closed 9 years ago

est31 commented 9 years ago

The delete command is useful for example when there are issues with the mapfile, or somebody wants to restore some griefing to nature.

fireglow commented 9 years ago

+1, I tested this on my server, where we had a hole in the map. //delete worked wonderfully.

Uberi commented 9 years ago

Looks good to me!

ShadowNinja commented 9 years ago

Seems like a duplication of functionality. The builtin command takes position params but it's othersise the same.

Also, this can be used for DoS if it's used with less-than-latest servers.

est31 commented 9 years ago

For DoS? Please explain? Is //set air more efficient than this command? Still I think this command is better because you can mistakenly set the wrong coordinates to the /deleteblocks command, but with //pos you immediately see the area to be removed.

ShadowNinja commented 9 years ago

Eh, nevermind the DoS issue, since you need the worldedit priv.

I think this should have a more descriptive name, like delete-blocks, so that players don't assume it's just an alias for set air.

est31 commented 9 years ago

ok, will change it to //deleteblocks.

est31 commented 9 years ago

changed.

est31 commented 9 years ago

now the commit message is changed too.

est31 commented 9 years ago

ok closing this, and re-opening with a new branch. dont want this pointing to my master branch.