search

Uberi / Yunit

Super simple testing framework for AutoHotkey.
GNU Affero General Public License v3.0
53 stars 21 forks source link

V2 Gui Changes by AutoHotkey v2.0-a103-56441b52 #27

Closed hoppfrosch closed 5 years ago

hoppfrosch commented 5 years ago

AHK v2.0-a103-56441b52 (or some eralier versions) introduced some incompatible changes in GUI commands:

Therefore Window.ahk throws error when usuing it.

-> This should be fixed

mmikeww commented 5 years ago

Ok I'll take a look.

Not sure why @lexikos didn't include these changes in the V2 UPDATES thread on the forum.. Or maybe I'm missing them somewhere

hoppfrosch commented 5 years ago

Thanks - had fixed it myself, but wasn't able to push to github through VPN/ssh channel I am using these days ...

Lexikos commented 5 years ago

I don't believe that MyGui.SetFont("s16, Arial") ever worked. SetFont has taken two parameters from the very beginning. See Lexikos/AutoHotkey_L@30a993d0. As far as I can recall, no GUI command or function has ever had comma-delimited options that weren't actual parameters (maybe excluding list values after Gui Delimiter has been used).

The Title parameter of Show was removed by Lexikos/AutoHotkey_L@779d8915 prior to v2.0-a079, which was the first release including the GUI objects. Only scripts written for fincs' build allowed title to be specified that way.

hoppfrosch commented 5 years ago

@Lexikos: Never noticed that SetFont() has a separate Parameter for Fontname. The syntax above worked until recently: therefore at least anything else has to be changed in this case... But that doesn't matter - the error above was detected by the parser and after the fix everything works fine

Lexikos commented 5 years ago

The invalid options were ignored, but it never worked; i.e. did not set the font family.

Helgef added validation to some functions. This is probably one of them.