Uberi / Yunit

Super simple testing framework for AutoHotkey.
GNU Affero General Public License v3.0
53 stars 21 forks source link

Fix unquoted attribute values #32

Closed SaifAqqad closed 3 years ago

SaifAqqad commented 3 years ago

Hey, the XML file generated by the JUnit module has some unquoted attribute values, which makes it incompatible with CI solutions

Here's the current output xml that is generated

<?xml version="1.0" encoding="UTF-8"?>
<testsuites failures=0 tests=7>
    <testsuite failures=0 tests=7 name="AHK_YUnit">
        <testcase name="VMType" classname="VMR_Test/>
        <testcase name="BusGain" classname="VMR_Test.Bus_Strip_Tests/>
        <testcase name="BusGainPercentage" classname="VMR_Test.Bus_Strip_Tests/>
        <testcase name="BusLimit" classname="VMR_Test.Bus_Strip_Tests/>
        <testcase name="BusMute" classname="VMR_Test.Bus_Strip_Tests/>
        <testcase name="StripColor" classname="VMR_Test.Bus_Strip_Tests/>
        <testcase name="StripLabel" classname="VMR_Test.Bus_Strip_Tests/>
    </testsuite>
</testsuites>

This commit should fix it completely

<?xml version="1.0" encoding="UTF-8"?>
<testsuites failures="0" tests="7">
    <testsuite failures="0" tests="7" name="AHK_YUnit">
        <testcase name="VMType" classname="VMR_Test"/>
        <testcase name="BusGain" classname="VMR_Test.Bus_Strip_Tests"/>
        <testcase name="BusGainPercentage" classname="VMR_Test.Bus_Strip_Tests"/>
        <testcase name="BusLimit" classname="VMR_Test.Bus_Strip_Tests"/>
        <testcase name="BusMute" classname="VMR_Test.Bus_Strip_Tests"/>
        <testcase name="StripColor" classname="VMR_Test.Bus_Strip_Tests"/>
        <testcase name="StripLabel" classname="VMR_Test.Bus_Strip_Tests"/>
    </testsuite>
</testsuites>
mmikeww commented 3 years ago

Merged. I was gonna say that we should also merge this into the v2 branch, but its likely that that is so far behind current v2 development that it doesnt even matter