UbiCollab / UbiCollabSDK

One jar file to rule them all.
1 stars 0 forks source link

MarketPlace identifier - define constant in SocialContract #12

Open JacquelineFloch opened 11 years ago

JacquelineFloch commented 11 years ago

Relates to the table Services - field URL

At the moment I can either

  1. downlaod a apk from any web site
  2. downlaod from Google Play.

In the first case URL should be set to the App url, e.g. http://folk.ntnu.no/svarvaa/utils/pro2www/apk/OsnapApp.apk

For the latter case, I suggest that we define constants e.g. "Google Play" set to what ever value you want :-) The URL should be set to that value if the App is available from the market. Currently I test whether the value is "https://play.google.com/store/apps" (i.e. the URL for Apps in Goole Play) - but I do not further use the value as Android provides support for going to the does not matter.

BabakFarshchian commented 11 years ago

I am wondering whether URL can be used for doing what you want to do Jacqueline. As I understand you want to know whether an app is on Google Play. For instance, Facebook for Android has a URL which is: https://play.google.com/store/apps/details?id=com.facebook.katana. It is easy to do a string check and see if the URL contains play.google.com as you suggest.

I am reluctant to add a new field because of these reasons:

Please comment.

BabakFarshchian commented 11 years ago

I am moving this to 0.5. Will handle it if it is still current.

JacquelineFloch commented 11 years ago

I do not want to have a new field! I simply want the URL https://play.google.com/store/apps to be used in the filed .URL

JacquelineFloch commented 11 years ago

Note that the solution I propose is more elegant since Android provides an API for starting the marketplace. The id of the App is given by the GLOBAL_ID

BabakFarshchian commented 11 years ago

I simply want the URL https://play.google.com/store/apps to be used in the filed .URL

Jacqueline, I am not sure I understand this. Probably to discuss in my office :-) SocialContract.Services.URL refers to the column in the Services table in the DB and its value is url. I cannot set it to be equal to https://play.google.com/store/apps. Do you mean you want https://play.google.com/store/apps to be the default value for URL?

JacquelineFloch commented 11 years ago

I suggested to define a constant as part of SocialContract.ServiceConstants (in the same way we have SERVICE_INSTALLED, etc. The constant might be GOOGLE_PLAY = https://play.google.com/store/apps In that way we avoid applications to define their own constants for something that is common to all.

Having it as a default value is a good suggestion. But it is a different issue, this was not my request.