Compile with libnotify 0.7.1 fails

[GoogleCodeExporter]

Please complete the following information about your configuration:
- FreetuxTV version: freetuxtv-0.5.1
- Linux distribution and version: Gentoo
- VLC version: 1.1.7
- ISP: Virgin Media

Describe here your problem:
FreetuxTV fails to compile with the newer version of libnotify (0.7.1 in this 
instance).

What is the expected output? What do you see instead?
A clean compile, but here is the compile error message:

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..  
-DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\" -DPACKAGE_SRC_DIR=\""."\" 
-DPACKAGE_DATA_DIR=\""/usr/share"\" -pthread -D_REENTRANT 
-I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 
-I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 
-I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng14 
-I/usr/include/libdrm -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include   
-I../lib/  -Wall -g -march=core2 -msse -msse2 -msse3 -mssse3 -msse4.1 -msahf 
-mcx16 -O2 -pipe -fomit-frame-pointer -MT main.o -MD -MP -MF .deps/main.Tpo -c 
-o main.o main.c
mv -f .deps/freetuxtv-window-main.Tpo .deps/freetuxtv-window-main.Po
mv -f .deps/freetuxtv-window-recording.Tpo .deps/freetuxtv-window-recording.Po
main.c: In function ‘freetuxtv_log’:
main.c:991: warning: cast from pointer to integer of different size
main.c: In function ‘main’:
main.c:1057: warning: cast to pointer from integer of different size
main.c:1078: error: too many arguments to function ‘notify_notification_new’
make[2]: *** [main.o] Error 1
make[2]: Leaving directory 
`/var/tmp/portage/media-tv/freetuxtv-0.5.1/work/freetuxtv-0.5.1/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory 
`/var/tmp/portage/media-tv/freetuxtv-0.5.1/work/freetuxtv-0.5.1'
make: *** [all] Error 2

Original issue reported on code.google.com by annunaki...@gmail.com on 16 Mar 2011 at 10:19

[GoogleCodeExporter]

I can confirm this (still Gentoo) with libnotify 0.7.2 and freetuxtv-0.5.1
(didn't test with 0.5.2 yet)

main.c:1078:3: erreur: too many arguments to function 
‘notify_notification_new’
/usr/include/libnotify/notification.h:114:21: note: declared here

Original comment by raphael....@gmail.com on 7 Apr 2011 at 10:06

[GoogleCodeExporter]

0.5.2 also fails

Original comment by raphael....@gmail.com on 7 Apr 2011 at 10:08

[GoogleCodeExporter]

Simply removing the last NULL argument line 1556 of main.c solves the problem, 
but the libnotify version dependency should be updated.

(see 
http://developer.gnome.org/libnotify/0.7/NotifyNotification.html#notify-notifica
tion-new)

Original comment by raphael....@gmail.com on 7 Apr 2011 at 10:16

[GoogleCodeExporter]

I see, but i have to make a compilation option for new and old version of 
libnotify, to be comptabible with current distribution like Ubuntu 10.10. 
Maybe, i will work on this tonight if I have time.

Original comment by Eric.Beu...@vixtechnology.com on 7 Apr 2011 at 11:52

[GoogleCodeExporter]

Original comment by eric.beuque on 9 Apr 2011 at 10:15

• Changed state: Accepted
• Added labels: Milestone-Release0.6.0, Priority-High, Type-Defect

[GoogleCodeExporter]

This issue was closed by revision r570.

Original comment by eric.beuque on 9 Apr 2011 at 11:31

• Changed state: Fixed

[GoogleCodeExporter]

Issue 128 has been merged into this issue.

Original comment by eric.beuque on 7 Oct 2012 at 9:26