search

UbiquityRobotics / fiducials

Simultaneous localization and mapping using fiducial markers.
BSD 3-Clause "New" or "Revised" License
265 stars 135 forks source link

Use subprocess for cairosvg to avoid lack of python2 support #165

Closed rohbotics closed 5 years ago

rohbotics commented 5 years ago

Fixes #161

The slowdown seems to be 2x, because of the process creation overhead.

@rfeistenauer You may want to try this out.

rohbotics commented 5 years ago

I think this is a known issue with the python modules, which is that there are 2 packages that provide the module em there is em and empy we use empy which has the template system.

pip install empy will install the correct package.

jim-v commented 5 years ago

I had empy installed already. I removed em and it worked. Could we do something like this to find the path to the correct module and import it explicitly?

rohbotics commented 5 years ago

Ok updated, it works now even if you have the wrong package from pip.

Please re-review.