search

UbiquityRobotics / fiducials

Simultaneous localization and mapping using fiducial markers.
BSD 3-Clause "New" or "Revised" License
265 stars 135 forks source link

Slam should not segfault when no fiducials are visible when initializing map #212

Closed rcywongaa closed 4 years ago

rcywongaa commented 4 years ago

Offending line: https://github.com/UbiquityRobotics/fiducials/blob/18672422d6a91299c4873e5be7824a7014508986/fiducial_slam/src/map.cpp#L446

Suggest that the system continue to attempt to initialize (by simply adding a return; after the line)

rohbotics commented 4 years ago

Hey @rcywongaa,

Sorry for the delay. This sounds like a reasonable change. Can you make a PR so that we can incorporate it?

Rohan

dorkamotorka commented 4 years ago

This is implemented.