search

UbiquityRobotics / learn

Ubiquity Robotics Tutorials Wiki
https://learn.ubiquityrobotics.com
15 stars 13 forks source link

Depricated command in documentation for Magni_nav #22

Closed davecrawley closed 6 years ago

davecrawley commented 6 years ago

In the documentation here: https://ubiquityrobotics.github.io/learn/rviz

It says:

On Magni, you can type:

roslaunch magni_viz view_nav.launch when navigation is running or roslaunch magni_viz view_robot.launch when it is not.

This doesn't work - I believe the issue is that this has become deprecated I believe the current correct command is:

roslaunch magni_nav move_base.launch

Please fix

jim-v commented 6 years ago

The launch files in magni_viz exist in the source repository, but a release has not been made since they were added. I thought we had come up with a scheme for having documentation that was accurate for both released and unreleased versions of the software.

davecrawley commented 6 years ago

I think we did a patch for the problem (regress the documentation to a point in time where it was believed everything was in sync). However this is not a flawless process, and evidently didn't work this time.

It seems that the correct solution is to do a release.

David

On Thu, May 3, 2018 at 10:57 AM, Jim Vaughan notifications@github.com wrote:

The launch files in magni_viz exist in the source repository, but a release has not been made since they were added. I thought we had come up with a scheme for having documentation that was accurate for both released and unreleased versions of the software.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/UbiquityRobotics/learn/issues/22#issuecomment-386382656, or mute the thread https://github.com/notifications/unsubscribe-auth/ALDeVjyP8E4I4T9J-9GV0qTYawAC3_N_ks5tu0UDgaJpZM4Tv5tX .

rohbotics commented 6 years ago

Closed as magni_viz is released now