UbiquityRobotics / learn

Ubiquity Robotics Tutorials Wiki
https://learn.ubiquityrobotics.com
15 stars 13 forks source link

Feature lidar setup #43

Closed JanezCim closed 2 years ago

JanezCim commented 2 years ago

Added LS lidar instructions to learn pages. This is a draft pull request because more discussion is yet to be done:

Unresolved questions:

Please rewiew the tutorials and give me feedback. Thanks!

JanezCim commented 2 years ago

launch lidars on our images in a more seamless fashion.

You mean that on the magni_robot repo, noetic branch? Any idea how to make it more seamless? Id be happy to hear it. :)

Implemented your suggestions @MoffKalast

MoffKalast commented 2 years ago

You mean that on the magni_robot repo, noetic branch? Any idea how to make it more seamless? Id be happy to hear it. :)

Yeah I think it may be worthwhile to have it as a yaml param much like sonars_installed, except lidar_type or lidar_model maybe. Much like it's done in ezmap kinetic right now for the time being. We could probably even add one for the rplidar with @mjstn's assistance.

JanezCim commented 2 years ago

@MoffKalast @mjstn i've now renamed the ls lidar into ur50 lidar in all the tutorials. i've also implemented @MoffKalast s suggestions. I think its now ready to be reviewed again. I think we think about adding tutorials for other lidars in other PRs

JanezCim commented 2 years ago

@MoffKalast and @mjstn this has been stale for some time now but its ready to be reviewed and merged if all is alright.