search

UbiquityRobotics / move_basic

A minimal navigation node
BSD 3-Clause "New" or "Revised" License
69 stars 21 forks source link

Sonar #27

Closed jim-v closed 6 years ago

jim-v commented 6 years ago

Add sonar-based obstacle detection in forward direction. https://github.com/UbiquityRobotics/move_basic/issues/26

jim-v commented 6 years ago

@rohbotics I would like to add the rotation obstacle detection and some tests before we merge.

jim-v commented 6 years ago

@rohbotics I haven't added the tests yet, but the code is written, so you are welcome to review it

jim-v commented 6 years ago

@rohbotics thanks for the review

jim-v commented 6 years ago

@rohbotics would you mind taking a look at the tests that I just added?

rohbotics commented 6 years ago

@jim-v Can this be merged?

jim-v commented 6 years ago

@rohbotics Yes. It needs to be modified to subscribe to a single Range topic, after UbiquityRobotics/loki_base_node/issues#3 is resolved, but that can be a separate PR