UbiquityRobotics / move_basic

A minimal navigation node
BSD 3-Clause "New" or "Revised" License
69 stars 21 forks source link

Fix extremely bad bug that incorrectly exited the linear move #69

Closed mjstn closed 3 years ago

mjstn commented 3 years ago

I was having a heck of a time with move basic exiting without moving forward at all.

Issue is the abs(remaining.x()) was used when we must use std::abs(remaining.x())

Without this fix move basic is close to useless ! This is an urgent fix!

I don't know what is on our images. The image may be ok, don't know.