Closed dorkamotorka closed 3 years ago
do you need only code review or do i need to test on Gazebo and/or real robot?
Please test both.
I created a Lidar class which can be useful in future if we would modify this node to be able to accept point from multiple lidar sources. Please re-test.
Object is created because we need to access lidar meta data from the callback and a method get_points and not only from the callback.
This PR improves LiDAR data storage in two ways:
I did profile the code myself on my PC and experienced 30-50% less time consumed on these for loops. To give you a sense in seconds - Firstly the for loop took ~140 microseconds, afterwards it took ~60 microseconds.