UbiquityRobotics / move_basic

A minimal navigation node
BSD 3-Clause "New" or "Revised" License
69 stars 21 forks source link

Level up perfomance of LiDAR storage & processing #79

Closed dorkamotorka closed 3 years ago

dorkamotorka commented 3 years ago

This PR improves LiDAR data storage in two ways:

I did profile the code myself on my PC and experienced 30-50% less time consumed on these for loops. To give you a sense in seconds - Firstly the for loop took ~140 microseconds, afterwards it took ~60 microseconds.

JanezCim commented 3 years ago

do you need only code review or do i need to test on Gazebo and/or real robot?

dorkamotorka commented 3 years ago

Please test both.

dorkamotorka commented 3 years ago

I created a Lidar class which can be useful in future if we would modify this node to be able to accept point from multiple lidar sources. Please re-test.

Object is created because we need to access lidar meta data from the callback and a method get_points and not only from the callback.