UbiquityRobotics / pi_image_build

GNU General Public License v2.0
16 stars 6 forks source link

added optional logclean line #14

Closed JanezCim closed 3 years ago

JanezCim commented 3 years ago

@MoffKalast suggested we add a README of some sort on the home directory to notify the user there is an option to uncomment logclean in magni-base.sh. Should we add that and how do we do it? Maybe just adding into the README of the magni_robot repo or this repo would be enough?

MoffKalast commented 3 years ago

In general I think it would be useful for people to have a ReadMe file directly in the home dir that explains some of the more unobvious aspects of the image:

Possibly some more? That's just what I can think of off the top of my head.

JanezCim commented 3 years ago

Yeah also we should add an example of a working ~/.ros/camera_info/extrinsics_demo.yaml, and a pointer towards it into this README that it exsists, cus noone actually is using it now and I think its a super nice feature

JanezCim commented 3 years ago

Okay @MoffKalast then maybe lets merge this if you agree and have another issue open for the README?