search

UbiquityRobotics / ubiquity_motor

Package that provides a ROS interface for the motors in UbiquityRobotics robots
BSD 3-Clause "New" or "Revised" License
25 stars 24 forks source link

Merge in to 4WD from main magni code the feature that will always set zero s… #136

Closed mjstn closed 3 years ago

mjstn commented 3 years ago

…peed when speed control is set to disable on topic /system_control

This merge is to address avalon branch issue #110 https://github.com/UbiquityRobotics/avalon/issues/110

mjstn commented 3 years ago

As a reviewer it is not your task to execute the code unless it satisfies you in some way.
In this case I did unit tests of the thing being fixed and because the way we do the stop of full control changed to be cleaner in magni I also put that in and manually tested the enable and disable there as well. I did not test beyond raw messages to be sure the disable and enable we use in fw upgrade would work. I did not test firmware upgrade as the thing effected was unit tested at lower level.