UbiquityRobotics / ubiquity_motor

Package that provides a ROS interface for the motors in UbiquityRobotics robots
BSD 3-Clause "New" or "Revised" License
25 stars 24 forks source link

upgrade_firmware.py syntax error #167

Closed JanezCim closed 2 years ago

JanezCim commented 2 years ago

Not entirely unexpected, the over the web MCB firmware upgrade fails in a string error (likely yet another phthon thang) Here is the failure:

ubuntu@pi-focal:~$ rosrun ubiquity_motor upgrade_firmware.py
-------------------------------------------------------------
Welcome to the Ubiquity Robotics Firmware Updater!

Please make sure that you are not running any ROS nodes.
- sudo systemctl stop magni-base

Note: Updating the firmware requires access to the internet.
-------------------------------------------------------------

Please enter your email address: mjstn2011@gmail.com
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/ubiquity_motor/upgrade_firmware.py", line 43, in <module>
    email = input("Please enter your email address: ").strip()
  File "<string>", line 1
    mjstn2011@gmail.com
             ^
SyntaxError: invalid syntax

_Originally posted by @mjstn in https://github.com/UbiquityRobotics/robot_testing/issues/27#issuecomment-1065961144_

JanezCim commented 2 years ago

Trying to solve in 6086adb0909ddde8a574fa93384201e983de829a but currently i got 500 server error:

ubuntu@pi-focal:~/catkin_ws/src/ubiquity_motor$ rosrun ubiquity_motor upgrade_firmware.py 
-------------------------------------------------------------
Welcome to the Ubiquity Robotics Firmware Updater!

Please make sure that you are not running any ROS nodes.
- sudo systemctl stop magni-base

Note: Updating the firmware requires access to the internet.
-------------------------------------------------------------

Please enter your email address: j.cimko@gmail.com
j.cimko@gmail.com
Error: 500 Internal Server Error. Something went wrong, try again in a few minutes. If the error persists, contact support.
JanezCim commented 2 years ago

I've also tried this with the unchanged code from kinetic-devel but on focal OS with python2 installed and got the same error. Could this be a server side error @rohbotics ?

anfederman commented 2 years ago

HMM... I saw the same thing, and thought it was a python thing. I used a kinetic image to upgrade to firmware 40, but did locally. When I tried oon Noetic I got the sting/error/server I don't recall if I got a token.

On Mon, Mar 14, 2022 at 7:32 AM Janez Cimerman @.***> wrote:

I've also tried this with the unchanged code from kinetic-devel but on focal OS with python2 installed and got the same error. Could this be a server side error @rohbotics https://github.com/rohbotics ?

— Reply to this email directly, view it on GitHub https://github.com/UbiquityRobotics/ubiquity_motor/issues/167#issuecomment-1066873381, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHZ375U2YHHED3MBY6CSO3U75EZFANCNFSM5QVPMIAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

JanezCim commented 2 years ago

500 Internal Server Error resolved with resolving the https://github.com/UbiquityRobotics/ubiquity_buildbot/issues/9