search

UbiquityRobotics / ubiquity_motor

Package that provides a ROS interface for the motors in UbiquityRobotics robots
BSD 3-Clause "New" or "Revised" License
24 stars 23 forks source link

Firmware instructions reference missing upgrade_firmware.py #79

Closed MoffKalast closed 4 years ago

MoffKalast commented 4 years ago

Firmware instructions at https://learn.ubiquityrobotics.com/firmware-upgrade reference missing script upgrade_firmware.py as it isn't packaged along with the compiled code.

The fix can be to either change the instructions to a git clone of the repository that has the script or to package the python scripts along with the compiled code.

rohbotics commented 4 years ago

@MoffKalast I just checked, and it looks like the script is being packaged as part of the deb. Can you explain what the error you encountered is?

MoffKalast commented 4 years ago

That does not seem to be the case on the magni I'm working on right now. The rosrun command lists the script as not found.

ubuntu@magni2:~$ roscd ubiquity_motor
ubuntu@magni2:/opt/ros/kinetic/share/ubiquity_motor$ ls
cmake  package.xml
ubuntu@magni2:/opt/ros/kinetic/share/ubiquity_motor$ ls cmake
ubiquity_motorConfig-version.cmake  ubiquity_motorConfig.cmake
rohbotics commented 4 years ago

roscd doesn't really work for binary packages, as all the components are placed in different places.

What happens when you run rosrun ubiquity_motor upgrade_firmware.py ?

Rohan

On Wed, Feb 12, 2020, 08:52 MoffKalast notifications@github.com wrote:

That does not seem to be the case on the magni I'm working on right now.

ubuntu@magni2:~$ roscd ubiquity_motor ubuntu@magni2:/opt/ros/kinetic/share/ubiquity_motor$ ls cmake package.xml ubuntu@magni2:/opt/ros/kinetic/share/ubiquity_motor$ ls cmake ubiquity_motorConfig-version.cmake ubiquity_motorConfig.cmake

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/UbiquityRobotics/ubiquity_motor/issues/79?email_source=notifications&email_token=AAVRY3YIWRMWOIMEL4GKCULRCQEJNA5CNFSM4KT26MJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELRBORI#issuecomment-585242437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVRY3YNAQYPH5FDDLW3BELRCQEJNANCNFSM4KT26MJQ .

MoffKalast commented 4 years ago

Well it looks in that very directory for some reason.

[rosrun] Couldn't find executable named upgrade_firmware.py below /opt/ros/kinetic/share/ubiquity_motor

rohbotics commented 4 years ago

Hey @MoffKalast

I just tried this again on the 2020-02-04 image, and it rosrun ubiquity_motor upgrade_firmware.py runs perfectly fine.

MoffKalast commented 4 years ago

¯\_(ツ)_/¯ May have something to do with removing and reinstalling packages then. I'll look into it more sometime.