UbuntuBudgie / budgie-extras

Additional Budgie Desktop enhancements for user experience
https://ubuntubudgie.org
GNU General Public License v3.0
177 stars 34 forks source link

Move pixmaps icons to hicolor #418

Closed fossfreedom closed 2 years ago

fossfreedom commented 2 years ago

Packaging guidelines state that icons that an app uses should not be saved in /usr/share/pixmaps - instead they should be installed in /usr/share/icons/hicolor/%{size}/apps/. This avoids an accidental upscaling of icons.

https://wiki.debian.org/AppStream/Guidelines

We should look to follow these guidelines which means

  1. ensuring the icons are of known standard sizes such as 64x64 / 32x32 etc
  2. meson.build should save those icons into the appropriate hicolor folder
Jacob-Vlijm commented 2 years ago

@fossfreedom Most of the icons (if not all) are symbolic/vector icons. We can't convert them to fixed sized, pixel-icons without creating issues with theming and losing quality?

fossfreedom commented 2 years ago

they would go in /usr/share/icons/hicolor/scalable/apps/

On Tue, 1 Feb 2022 at 18:59, Jacob Vlijm @.***> wrote:

Most of the icons are symbolic/vector icons. We can't convert them to fixed sized, pixel-icons without creating issues with theming and loosing quality?

— Reply to this email directly, view it on GitHub https://github.com/UbuntuBudgie/budgie-extras/issues/418#issuecomment-1027181796, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHTHEDE44F6OSNS5DWUOE3UZAUQFANCNFSM5NJ6PYZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

Jacob-Vlijm commented 2 years ago

Ah.