New icons for Weathershow

UbuntuBudgie / budgie-extras

Additional Budgie Desktop enhancements for user experience

https://ubuntubudgie.org

GNU General Public License v3.0

175 stars 34 forks source link

New icons for Weathershow #437

Closed GrindamN closed 1 year ago

GrindamN commented 1 year ago

I have added new icons for weathershow so that we are more up to date. In the same folder there is a readme with attribution.

fossfreedom commented 1 year ago

MIT license and attribution and repo is https://github.com/basmilius/weather-icons

GrindamN commented 1 year ago

Added. Forgot to copy the license to the subfolder where icons are located. More info also added to the readme.

Jacob-Vlijm commented 1 year ago

Definitely nicely and modern looking set of icons. A few issues though:

For use in WeatherShow, animated icons are a no go imo. Keep in mind these icons are potentially also used for permanent presence on the desktop and/or in the menu. Would be extremely annoying, having to look at an ongoing animation.
Visibility of light clouds might not really be appropriate to some more serious weather situations :), but you fixed their visibility on light themes anyway nicely by the thin outline. That does not go for e.g. the snowflakes, they are completely invisible on a lighter background.

GrindamN commented 1 year ago

Thanks for the comments Jacob!

Yeah, true. However I've noticed that despite being animated on Github, they are not animated on the desktop or notification tray. I think it has to do with DE not supporting animations. I'll see to remove the animate tag, and if I miss any, just notify me.
That's a good point actually. Maybe some border on the outline would be good. As for the serious weather situations and light clouds, I'm on open for suggestions :)

Jacob-Vlijm commented 1 year ago

I have been playing around with this (beautiful) set and used it in the application. Currently, the set has too big an empty area around the icons, so showing too small in the allocated space. Removing the space, another issue occurs: while the original set was made to more or less fill a "square", this set has more variety in proportions hor/vert, which is an issue when the option to show a "live" icon in the panel is set. Then we can't simply use optimal space for the icon (and we really need to), since we need to take into account the widest oriented icon, on a horizontal panel, and vice versa on a vertical panel. Not sure what to do. Rearranging & repositioning the existing elements, even reshaping some, squeeze them into a square is a huge job, if we want to do it in a consistent way. Let alone the fact that the original creator probably won't be thrilled. I do agree we could use a new set though.

fossfreedom commented 1 year ago

A query folks.

For the desktop and also the possible raven widget they show one weather icon at a time. Does the variation you mention make a material impact? I e. Would an end user actually notice?

Yes I know this sounds like having two iconsets .... but something to consider.

Jacob-Vlijm commented 1 year ago

Think user would. Styles are completely different, representation in the panel would clash with raven/desktop. Also in the forecast, four icons show in a row.

fossfreedom commented 1 year ago

merged to the weathericons branch