search

UbuntuBudgie / budgie-extras

Additional Budgie Desktop enhancements for user experience
https://ubuntubudgie.org
GNU General Public License v3.0
175 stars 34 forks source link

Brightness - night light #441

Closed Quasicitizen closed 1 year ago

Quasicitizen commented 1 year ago

Howdy! I have Night Light enabled sunset to sunrise and BrightnessController applet in top panel. AND when I touch the BC cog, Night Light disables. I have to go and re-enable it from settings. Is this a bug or is it me?

fossfreedom commented 1 year ago

Screenshots please ... not sure what options you are seeing and clicking. Thx.

Quasicitizen commented 1 year ago

2 1

Quasicitizen commented 1 year ago

Now I added NL to top bar, to access it more quickly after it is being disabled when interacting with Brightness :)

samlane-ma commented 1 year ago

The issue appears to be that when opening the popup, or after a short timeout after loading, it restores saved settings, and will override the night light color.

Right solution would probably be for the applet to not change the color on load / popover if night mode is currently scheduled to on at that time?

Or at least don't load if the auto nightlight is toggled on at all?

Quasicitizen commented 1 year ago

The issue appears to be that when opening the popup, or after a short timeout after loading, it restores saved settings, and will override the night light color.

Right solution would probably be for the applet to not change the color on load / popover if night mode is currently scheduled to on at that time?

Or at least don't load if the auto nightlight is toggled on at all?

Absolutely! When NL is on by schedule, 22:00-08:00 I have to interact with brightness reducing it every time, and after every interaction with brightness I have to keep interacting with NL aswell, because it disappears, even though applet indicates it is on.

samlane-ma commented 1 year ago

I have taken a closer look at this. It appears via dBus, we can access the NightLightActive property of org.gnome.SettingsDaemon.Color to peek at whether the nightlight mode is active. Should it be active, we can skip changing the color whenever the popup is opened, and when the applet first loads. The benefit of this way is: 1) it will still work correctly if the nightlight mode is toggled on, but outside of the scheduled active time 2) since nightlight slowly changes the color starting from an hour before the scheduled time, it will cover this period as well.

Seems quite viable from early testing.