UbuntuBudgie / budgie-extras

Additional Budgie Desktop enhancements for user experience
https://ubuntubudgie.org
GNU General Public License v3.0
175 stars 34 forks source link

WallStreet : always shows pictures randomly #450

Closed Coeur-Noir closed 1 year ago

Coeur-Noir commented 1 year ago

Hi,

seems like wall Street always shows pictures randomly, even if « random » is not ticked in its settings.

Let's say one might want to slideshow background pictures in a specific ordered sequence,

it's not possible.

Test : have a folder where pictures are named 00.jpg 01.jpg 02.jpg and so on… I'd expect to see them as backgrounds sorted by their name.

That would allow some kind of scenario / animation for backgrounds pictures.

fossfreedom commented 1 year ago

Hmm - doesn't look like this part of the method where we read the list of filenames in a folder is sorting the filenames

https://github.com/UbuntuBudgie/budgie-extras/blob/43aae641fbb31a4591d5f43110a3871310a5590f/budgie-wallstreet/src/wallstreet/wallstreet.vala#L185

Probably should be using GenericArray's rather than a string array https://valadoc.org/glib-2.0/GLib.GenericArray.sort.html so that we can sort the names being read from the folder

fossfreedom commented 1 year ago

@Coeur-Noir This can now be tested via our daily PPA

https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/budgie-extras-daily