search

UbuntuBudgie / budgie-extras

Additional Budgie Desktop enhancements for user experience
https://ubuntubudgie.org
GNU General Public License v3.0
175 stars 34 forks source link

Kilometers Per Hour #472

Open ItalicIntegral opened 5 months ago

ItalicIntegral commented 5 months ago

Good day,

I noticed that we have a checkbox to change from M/S to MPH. Would it be possible to add Km/h?

fossfreedom commented 5 months ago

This is for the weather applet? The windspeed calculation is here - https://github.com/UbuntuBudgie/budgie-extras/blob/2c92ddb3343e8637503723f698ade0477abc1caa/budgie-weathershow/src/weathershow/WeatherShow.vala#L611

Happy to receive a suitable pull-request.

Jacob-Vlijm commented 5 months ago

Maybe better show the two at once then, like: 10m/s (36 km/h) Saves another checbox.

ItalicIntegral commented 5 months ago

I don't think making the field multi-unit is a good idea. I believe that the field should be a dropdown and not a check box. Furthermore, the unit that one is seeking depends on location and possibly on profession. The meter per second M/S is the SI unit recommended by the World Meteorological Society and is used in Nordic countries so I would make it the default. However, other units such as Km/h, MPH, ft/s, knots, and Beaufort are also used by some. We probably don't need to get fancy with historical units like Beaufort but the others can be directly derived from the SI unit.

I'm not a programmer. I did look through the code but I'm not even sure how to make a pull request is otherwise I would help.

image