search

UbuntuBudgie / budgie-welcome

Welcome app for Ubuntu Budgie
GNU General Public License v2.0
46 stars 28 forks source link

add a gaming section to budgie-welcome #151

Closed fossfreedom closed 2 years ago

fossfreedom commented 6 years ago

we've discussed this a while back. I'm not a gamer here - so I would like someone to lead with the detail here.

From my view point - the steam installer in recommendations should at the very least be replaced with the excellent snap steam install due very soon from ikey.

HellBringer419 commented 3 years ago

So I did those changes:

Also, screenshots:

Games

tools new

Please send out opinions. Also, I've been enjoying a lot of retro games lately, mostly snes. So, should we add them?

fossfreedom commented 3 years ago

Personally I would use the youtube logo and make it a clickable link. That means no need for text and therefore reduces the amount of translations needed.

HellBringer419 commented 3 years ago

I couldn't find the YT logo as a material icon. Closest was the 'play icon'. So, revert back to 'play' icon with watch trailer on YT or add a YT img as a button ?

fossfreedom commented 3 years ago

For the logo - we should use the YouTube asset - their terms and conditions dictate this. So use the "image button" type approach as per Patreon and Paypal on the donate page - maybe just the YouTube icon further down the page.

https://www.youtube.com/howyoutubeworks/resources/brand-resources/#logos-icons-and-colors

HellBringer419 commented 3 years ago

So something like this: with YT logo

The Youtube is clickable

fossfreedom commented 3 years ago

Yep - that works for me.

On Wed, 27 Oct 2021 at 10:42, Uday Narayan Mukherjee < @.***> wrote:

So something like this: [image: with YT logo] https://user-images.githubusercontent.com/35007817/139041262-116ebfd3-a5f5-48b3-8743-edcfc6537f09.png

The Youtube is clickable

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UbuntuBudgie/budgie-welcome/issues/151#issuecomment-952735343, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHTHEA3M46DX33PBJYT3VLUI7CQNANCNFSM4EDVDLMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

HellBringer419 commented 3 years ago

Hi @ilvipero & @fossfreedom, the 3 tab view is now complete and a PR has been raised for this.

Screenshots of current view of gaming section:

pic 1

Pic 2

Pic 3

Pic 5

Hope you guys like it too :)

fossfreedom commented 3 years ago

Remember ... I don't play games ...

Should this package be installed at the same time with steam etc?

https://packages.ubuntu.com/impish/gamemode

ilvipero commented 3 years ago

Remember ... I don't play games ...

Should this package be installed at the same time with steam etc?

https://packages.ubuntu.com/impish/gamemode

Installed at the same time with steam I would say no. Linux users don't like to be told what to do. But having gamemode available in our list of gaming related software as a separate item? That would be ok.

Rest looks great really, can't wait to test it.

fossfreedom commented 3 years ago

All - test snap now available - please do try 

snap refresh --edge ubuntu-budgie-welcome
HellBringer419 commented 3 years ago

Regarding game-mode? I agree it's not the best idea to install it with steam, but there is a point in suggesting it. Maybe as one of the tools.

Also, what I had in mind that since a workable build is out there, we should stop and see what the community thinks ... and then move forward.

HellBringer419 commented 3 years ago

Also @fossfreedom , I tried to test the new build with the snap command.

It's giving error: channel not found. I'm running this command on a minimal installation of Ubuntu Budgie. Could this be the issue ?

fossfreedom commented 3 years ago

ah - my bad - should be snap refresh --edge ubuntu-budgie-welcome

HellBringer419 commented 3 years ago

Thanks that works.

Also @fossfreedom , I forgot to fix the polychromatic package json. ppa is repeated twice and it should be once only. How do I send out a fix ? via PR ?

It's essentially in https://github.com/UbuntuBudgie/budgie-welcome/blob/4767695a1785277f2927181591bd7e6cd9375632/data/config/packages.json#L1404 it would be: 'ppa:polychromatic/stable and not 'ppa:ppa:polychromatic/stable'

fossfreedom commented 3 years ago

Thx. I will push a fix for this issue soonish. Cheers.

On Sat, 30 Oct 2021, 14:26 Uday Narayan Mukherjee, @.***> wrote:

Thanks that works.

Also, I forgot to fix the polychromatic package json. ppa is repeated twice and it should be once only. How do I send out a fix ? via PR ?

It's essentially in https://github.com/UbuntuBudgie/budgie-welcome/blob/4767695a1785277f2927181591bd7e6cd9375632/data/config/packages.json#L1404 it would be: 'ppa:polychromatic/stable and not 'ppa:ppa:polychromatic/stable'

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UbuntuBudgie/budgie-welcome/issues/151#issuecomment-955208990, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHTHEHLJFADCKHRPEA7DXLUJPW6RANCNFSM4EDVDLMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

fossfreedom commented 3 years ago

@HellBringer419 quick feedback - clicking on images such as the lutris image displays it ... but no way to navigate back.

Jacob-Vlijm commented 3 years ago

The issue seems to be a bit more then just a navigation error. Clicking on the close-button only works after repeated clicks. Window seems frozen -ish.

fossfreedom commented 3 years ago

In this context I don't see a reason for the images being clickable https://github.com/UbuntuBudgie/budgie-welcome/blob/master/data/gaming.html#L44 ... n.b. if we have to use a lightbox then at a minimum this bit of javascript is needed https://github.com/UbuntuBudgie/budgie-welcome/blob/master/data/default.html#L616

HellBringer419 commented 3 years ago

Would you guys want to just an image with no onClick ? I was following the applets page for this.

Will revert to img tags

fossfreedom commented 3 years ago

Yeah ... no "a href" type stuff ... simple img tags.

fossfreedom commented 3 years ago

Just to clarify ... simple img syntax like https://github.com/UbuntuBudgie/budgie-welcome/blob/4767695a1785277f2927181591bd7e6cd9375632/data/features.html#L32

HellBringer419 commented 3 years ago

Done that. There were anchor tags for lightbox and I removed them.

HellBringer419 commented 3 years ago

yay !! It got merged

@ilvipero we should raise awareness that this is coming (possibly in the next release). Hype it ?!! ;-p

ilvipero commented 3 years ago

@HellBringer419 already posted a couple of times and thanked you directly on Twitter, Mastodon, and Facebook. Thanks a lot for your great work. Hopefully we get more people involved and aware of this awesome feature. I am personally testing install of tools and making sure it all runs smoothly. https://twitter.com/UbuntuBudgie/status/1455494535430098945

HellBringer419 commented 3 years ago

Thank you so much. Also, it's not my own efforts only. You helped revive it and David helped me understand the code.

But yeah cool work mate :)

HellBringer419 commented 2 years ago

Should we close this issue after release ?