search

UbuntuBudgie / pocillo-gtk-theme

GTK+ 3.22 & GTK+ 4 based theme for the Budgie Desktop that has Material Design elements and styled using the Arc colour palette
https://ubuntubudgie.org
GNU General Public License v2.0
47 stars 10 forks source link

[UB 20.10] Firefox menu bar transparent gap #27

Closed dblueman closed 3 years ago

dblueman commented 4 years ago

On Ubuntu Budgie 20.10 with any of the 6 Pocillo theme choices, on my 15.6" 4K Dell XPS laptop, there is a consistent 1 pixel transparent gap underneath the Firefox menu bar: budgie-bug2 Scaled up for easier viewing: budgie-bug3

This doesn't occur on any of the other supplied themes, so does appear to be an issue with Pocillo. As I'm not familiar with which elements are involved, can someone point me at what changes I can test?

fossfreedom commented 4 years ago

firefox theming is here https://github.com/UbuntuBudgie/pocillo-gtk-theme/blob/fe3876155e192a1d70e87c4be1576c85a1e22174/src/gtk-3.0/3.22/sass/apps/_third-party.scss#L56

fossfreedom commented 4 years ago

@dblueman I've looked at both 200% HiDPI and standard resolutions and cannot reproduce your issue here on both 20.04 and 20.10

Do please check a clean firefox profile to see if its an extension issue.

Also do check with Pocillo icon theme as well since I can see you are using a different icon-theme.

dblueman commented 3 years ago

I booted the Ubuntu Budgie 20.10 install stick and also couldn't reproduce it with my settings.

The issue does reproduce even if I create a totally new user account, so looks like it is an installed package is altering affecting the appearance. I'll investigate the SCSS.

fossfreedom commented 3 years ago

@dblueman that commit should hopefully resolve this issue.

dblueman commented 3 years ago

Perfect! I built master, installed and reloaded; the issue is resolved nicely.

fossfreedom commented 3 years ago

excellent. I'll backport this to 20.10 & 20.04 soonish.

Please run ubuntu-bug ubuntu-budgie-themes to report the issue to launchpad - then I'll have something to reference as part of the updated package release.

On Thu, 19 Nov 2020 at 06:36, Daniel J Blueman notifications@github.com wrote:

Perfect! I built master, installed and reloaded; the issue is resolved nicely.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/UbuntuBudgie/pocillo-gtk-theme/issues/27#issuecomment-730162680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHTHEGWOIF4NBSDOZJ3UXTSQS4IPANCNFSM4TODEXDQ .

dblueman commented 3 years ago

Superb! Logged it at: https://bugs.launchpad.net/ubuntu/+source/budgie-artwork/+bug/1905118