search

UbuntuBudgie / pocillo-gtk-theme

GTK+ 3.22 & GTK+ 4 based theme for the Budgie Desktop that has Material Design elements and styled using the Arc colour palette
https://ubuntubudgie.org
GNU General Public License v2.0
47 stars 10 forks source link

Wireless signal strength icon not visible on default background color #3

Open fossfreedom opened 6 years ago

fossfreedom commented 6 years ago

From @joaofl on April 18, 2018 17:22

When choosing a wireless connection to connect to, the user can only see the signal strength icon (those little bars) when the mouse is over one of them, when the background changes to blue. Otherwise, those are white bars on white background (at least by default).

Copied from original issue: UbuntuBudgie/budgie-indicator-applet#16

fossfreedom commented 6 years ago

Screenshot?

fossfreedom commented 6 years ago

From @joaofl on April 18, 2018 22:47

Note that the signal strength bar is only visible when under the blue highlight

workspace 1_005

fossfreedom commented 6 years ago

ah - thanks. Can confirm with Pocillo - that is the theme you are using? Not sure though what bit of CSS will need to change to fix.

fossfreedom commented 6 years ago

From @joaofl on April 18, 2018 23:31

My theme config is the default of the Ubuntu Budgie 17.10, which is: Widgets: ARC Icons: Pocillo

fossfreedom commented 6 years ago

Hmm I still think this is a theming issue.

This is the network manager applet btw not budgie indicator

fossfreedom commented 6 years ago

From @joaofl on April 19, 2018 13:1

Let me know if I can help with anything.

fossfreedom commented 6 years ago

@joaofl if you can please try other "light" themes and see how network manager and the wireless icons cope with the light theme.

This will help to confirm if this is a theme issue or a bug with upstream network-manager. Icons should normally be "symbolic" - GTK switches to dark or light icons depending up the theme contrast.

fossfreedom commented 6 years ago

From @joaofl on April 20, 2018 12:54

All the others I tested the icons show in gray, so its fine. Which means that this is an issue with the theme itself. Those icons should not be white. Maybe I can try to fix it

fossfreedom commented 6 years ago

Many thanks for the feedback - it would be much appreciated if you can have a go and fixing it.

fossfreedom commented 6 years ago

From @joaofl on April 20, 2018 12:59

I would gladly contribute. Can you at least point aproximately where this should be? Not really familiar with the ubuntu themes. Guess it is here? https://github.com/UbuntuBudgie/pocillo-gtk-theme/tree/master/src

fossfreedom commented 6 years ago

correct - as per the README, changes should be done in the sass files. Compilation instructions are in the README

the "apply" script is useful because it compiles the theme, installs it and activates the theme all in one hit.

When developing themes you have to change to something else and then back again to see the theme changes - if you have a look at the apply script (its just a text file) then you see how this is automated.