style: Declaration of Variables

[jmoeckel]

Following rule 3.8 we should use units for variables, that have a physical correspondence - and if possible use types from Modelica.SIUnits.

There exists lot of variables in the BuildingSystems, that are declared as Real (without a unit) but have a physical correspondece.

---

Following files contain the keyword Real and were NOT copied from Annex60. Files from package Types some subpackages of Utilities are not considered as they do not use physical quantities:

---

• [x] buildings\airvolumes\airvolumecompressible0d.mo
• [x] buildings\airvolumes\airvolume3d.mo
• [x] buildings\baseclasses\airpathgeneral.mo
• [x] buildings\baseclasses\relationradiationconvection.mo
• [x] buildings\baseclasses\zonetemplategeneral.mo
• [x] buildings\buildingtemplates\building1zone0d_vis3d.mo
• [x] buildings\buildingtemplates\building1zone0ddistrict_vis3d.mo
• [x] buildings\buildingtemplates\building1zone1dcylinder_vis3d.mo
• [x] buildings\buildingtemplates\building1zone0ddistrict.mo
• [x] buildings\constructions\walls\wallthermal3d_vis3d.mo
• [x] buildings\constructions\walls\wallthermal1dnodes_vis3d.mo
• [x] buildings\constructions\windows\radiationtransmission.mo
• [x] buildings\constructions\windows\window.mo
• [x] buildings\constructions\windows\window_vis3d.mo
• [x] buildings\data\airpathcharacteristics\airpathcharacteristicwindow.mo
• [x] buildings\data\airpathcharacteristics\cdtiltedpane.mo
• [x] buildings\zones\zonetemplateairvolumemixed.mo
• [x] buildings\airpathes\airpathconstant.mo
• [x] buildings\airpathes\airpathprescribedpressure.mo
• [x] buildings\functions\tair.mo
• [x] buildings\functions\tsky.mo
• [x] buildings\functions\pair.mo
• [x] buildings\functions\vwind.mo
• [x] buildings\interfaces\airpathportgeneral.mo
• [x] buildings\ambient.mo
• [x] climate\solarradiationtransformers\solarradiationtransformergeneral.mo
• [x] fluid\fixedresistances\pipe.mo
• [x] ham\convectiveheattransfer\surfaces\alphaplatefree.mo
• [x] ham\data\materialproperties\baseclasses\materialhygrothermalgeneral.mo
• [x] ham\heatandmoisturetransport\baseclasses\heatandmoisturetransportgeneral.mo
• [x] ham\heatandmoisturetransport\functions\examples\dphi.mo
• [x] ham\heatandmoisturetransport\functions\dphi.mo
• [x] ham\heatandmoisturetransport\functions\interpol.mo
• [x] ham\heatandmoisturetransport\functions\phisor.mo
• [x] ham\heatandmoisturetransport\functions\wderphi.mo
• [x] ham\heatandmoisturetransport\functions\wsor.mo
• [x] ham\heatandmoisturetransport\heatandmoisturetransport1d.mo
• [x] ham\heatandmoisturetransport\heatandmoisturetransport1dnodes.mo
• [x] ham\heatandmoisturetransport\heatandmoisturetransport3d.mo
• [x] ham\heatconduction\heatconduction1d_vis3d.mo
• [x] ham\heatconduction\heatconduction3d.mo
• [x] ham\heatconduction\heatconduction1d.mo
• [x] technologies\chillers\data\compressionchillers\compressionchillergeneral.mo
• [x] technologies\chillers\compressionchiller.mo
• [x] technologies\electricalstorages\batterysimple.mo
• [x] technologies\photovoltaics\baseclasses\electricalmodels\electricalmodelonediodegeneral.mo
• [x] technologies\photovoltaics\baseclasses\electricalmodels\electricalmodeltwodiodesgeneral.mo
• [x] technologies\photovoltaics\baseclasses\electricalmodels\electricalmodeltwodiodesmpp.mo
• [x] technologies\photovoltaics\baseclasses\electricalmodels\electricalmodelgeneral.mo
• [x] technologies\photovoltaics\baseclasses\thermalmodels\thermalmodelsimple.mo
• [x] technologies\photovoltaics\baseclasses\pvmodulegeneral.mo
• [x] technologies\photovoltaics\data\photovoltaicmodules.mo
• [x] technologies\photovoltaics\pvmodules\pvmodulesimple.mo
• [x] technologies\photovoltaics\pvmodules\pvmodulesimplempp.mo
• [x] technologies\solarthermal\data\collectors\collectorpartial.mo
• [x] technologies\solarthermal\thermalcollector.mo
• [x] technologies\thermalstorages\baseclasses\buoyancymodels\buoyancy1.mo
• [x] technologies\thermalstorages\baseclasses\buoyancymodels\buoyancy2.mo
• [x] technologies\thermalstorages\baseclasses\stratificationmodel\partialinletstratification.mo
• [x] utilities\moistairfunctions\t_sat.mo
• [x] utilities\moistairfunctions\enthalpy.mo
• [x] utilities\moistairfunctions\p.mo
• [x] utilities\moistairfunctions\p_sat.mo
• [x] utilities\moistairfunctions\t_dp.mo

[jmoeckel]

Note: This is just a first shot. Future work is necessary to find all Real variable, that could be redeclared as a physical quantity.