search

UdK-VPT / BuildingSystems

Modelica BuildingSystems library
http://modelica-buildingsystems.de/
BSD 3-Clause "New" or "Revised" License
68 stars 33 forks source link

Inconsistent dependencies in master version of the library #171

Closed casella closed 2 years ago

casella commented 2 years ago

PR #169 updated the library to use Modelica version 4.0.0. Unfortunately, the library still uses NCDataReader2 v. 2.5.0, which still uses Modelica 3.2.3. Hence, the OpenModelica package manager is unable to resolve the dependencies correctly, causing Modelica 3.2.3 to be loaded and ending up in testing failure.

The library should be updated to use a version of NCDataReader2 that uses Modelica 4.0.0.

casella commented 2 years ago

Keeping @sjoelund in the loop.

nytschgeusen commented 2 years ago

The submodule NCDataReader2 has been updated to version 2.5.1 in the master branch, which uses Modelica 4.0.0 as well as the BuildingSystems library.

sjoelund commented 2 years ago

That won't help as long as the uses-annotation is 2.5.0: https://github.com/UdK-VPT/BuildingSystems/blob/e48276e86955b4a6e46bf984f867281ee0216868/BuildingSystems/package.mo#L10

I would also suggest tagging a 2.5.1 (or 2.5.1-beta.1 or something) of that library in order for the dependencies to resolve in the future.

nytschgeusen commented 2 years ago

Martin, thanks for the hint. I have adapted the version to 2.5.1 in the named package.mo file.

casella commented 2 years ago

Thanks @nytschgeusen!

It will probably take a couple of days for these changes to ripple through our CI system, please check the library report in a few days and let us know if it still doesn't work.