search

UdK-VPT / BuildingSystems

Modelica BuildingSystems library
http://modelica-buildingsystems.de/
BSD 3-Clause "New" or "Revised" License
70 stars 34 forks source link

Issue170 ibpsa library 2022 feb #172

Closed thorade closed 2 years ago

thorade commented 2 years ago

this will close #170

Merged IBPSA lib, following the guide at https://github.com/UdK-VPT/BuildingSystems/wiki/IBPSA-Integration

IBPSA master is at commit fc4195ff7afc3c3721f0cddf33ba5b1e824cf753 https://github.com/ibpsa/modelica-ibpsa/commit/fc4195ff7afc3c3721f0cddf33ba5b1e824cf753

The last IBPSA integration run was in PR https://github.com/UdK-VPT/BuildingSystems/pull/165 in 2021-08-09, non-backward-compatible changes since then are listed here: https://git.io/vdFUu https://git.io/vFGqf

thorade commented 2 years ago

@BreadKM can you please checkout this branch, then do some manual testing? Just open up some of the executable models and see whether they still run without error messages, also run Dymola "Check model". BuildingSystems does not use regression testing yet to compare simulation results.

BreadKM commented 2 years ago

@thorade Thanks for creating pull request. I did testing for some models and they ran without any issues in Dymola. I used Dymola Version 2022x (64-bit), 2021-10-08 with Modelica version 4.0.0.

nytschgeusen commented 2 years ago

The branch is working fine, I only corected a small typo in model https://github.com/UdK-VPT/BuildingSystems/blob/master/BuildingSystems/Buildings/Zones/Examples/SingleZoneThermal3x3x3ViewFactors.mo