UdK-VPT / BuildingSystems

Modelica BuildingSystems library
http://modelica-buildingsystems.de/
BSD 3-Clause "New" or "Revised" License
70 stars 34 forks source link

Illegal inheritance in BuildingSystems.Utilities.Visualisation3D.Modelica3D #20

Closed tbeu closed 8 years ago

tbeu commented 9 years ago
Warning while loading the file f:\Libraries\BuildingSystems\BuildingSystems\Utilities\Visualisation3D\Modelica3D\Setup.mo.
The Modelica class of BuildingSystems.Utilities.Visualisation3D.Modelica3D.Setup.ExtSetup (model) and its base class BuiltIn.ExternalObject (type) are not compatible.
Message: Modelica.IncompatibleBaseClass

Warning while loading the file f:\Libraries\BuildingSystems\BuildingSystems\Utilities\Visualisation3D\Modelica3D\VisConfig.mo.
The Modelica class of BuildingSystems.Utilities.Visualisation3D.Modelica3D.VisConfig.ExtVisConfig (model) and its base class BuiltIn.ExternalObject (type) are not compatible.
Message: Modelica.IncompatibleBaseClass

Warning while loading the file f:\Libraries\BuildingSystems\BuildingSystems\Utilities\Visualisation3D\Modelica3D\Setup.mo.
The Modelica class of BuildingSystems.Utilities.Visualisation3D.Modelica3D.Setup.ExtSetup (model) and its base class BuiltIn.ExternalObject (type) are not compatible.
Message: Modelica.IncompatibleBaseClass

Warning while loading the file f:\Libraries\BuildingSystems\BuildingSystems\Utilities\Visualisation3D\Modelica3D\VisConfig.mo.
The Modelica class of BuildingSystems.Utilities.Visualisation3D.Modelica3D.VisConfig.ExtVisConfig (model) and its base class BuiltIn.ExternalObject (type) are not compatible.
Message: Modelica.IncompatibleBaseClass
thorade commented 9 years ago

Thanks. We will look into it, the whole 3D Visualization part will probably see a lot of changes anyway. But this is not a top priority.

To reproduce the error (or a related error) in Dymola, run

Advanced.PedanticModelica:=true;
checkModel("BuildingSystems.Utilities.Visualisation3D.Modelica3D");

The resulting error message is:

Component type specifier ExtSetup is a model, that should not be used in a function
File: C:/Users/mthorade/Documents/Dymola/BSgithub/BuildingSystems/Utilities/Visualisation3D/Modelica3D/Setup.mo, line 10
Error: Component type specifier ExtSetup is a model, this cannot be combined with the prefix output .
File: C:/Users/mthorade/Documents/Dymola/BSgithub/BuildingSystems/Utilities/Visualisation3D/Modelica3D/Setup.mo, line 10
Component context: setup
Component declared as ExtSetup setup in BuildingSystems.Utilities.Visualisation3D.Modelica3D.Setup
thorade commented 9 years ago

There are some models that do not comply with the Modelica language specification. The spec says:

A function may only contain components of the restricted classes 
type, record, operator record, and function; 
i.e. no model or block components.

https://modelica.org/documents/ModelicaSpec33Revision1.pdf#page=141

nytschgeusen commented 8 years ago

The package BuildingSystems.Utilities.Visualisation3D.Modelica3D is not longer part of the building systems library, because it was shifted to the BuildingSystems_Vis3D library