search

UdK-VPT / BuildingSystems

Modelica BuildingSystems library
http://modelica-buildingsystems.de/
BSD 3-Clause "New" or "Revised" License
70 stars 34 forks source link

invalid connect in Technologies.SolarThermal #94

Closed thorade closed 7 years ago

thorade commented 7 years ago

Some connect equations are strange/wrong in the ThermCollector model, e.g. this one: https://github.com/UdK-VPT/BuildingSystems/blob/0361fc68c98284669256360db5aea337f3411dd4/BuildingSystems/Technologies/SolarThermal/ThermalCollector.mo#L166

And the ThermalCollectorInSeries model uses [end] in connect statement: https://github.com/UdK-VPT/BuildingSystems/blob/0361fc68c98284669256360db5aea337f3411dd4/BuildingSystems/Technologies/SolarThermal/ThermalCollectorInSeries.mo#L76

See more warnings/errors by simulating (with OpenModelica) the example Technologies.SolarThermal.Examples.BigCollectorInstallationWithStorage or look at the errorlog here: https://libraries.openmodelica.org/branches/v1.12/BuildingSystems/files/BuildingSystems_BuildingSystems.Technologies.SolarThermal.Examples.BigCollectorInstallationWithStorage.err