search

UdK-VPT / Open_eQuarter

Open eQuarter plugin repository.
http://UdK-VPT.GitHub.io/Open_eQuarter
GNU General Public License v2.0
10 stars 5 forks source link

Importing statistic correlations in external scripts #64

Closed thorade closed 1 year ago

thorade commented 8 years ago

This replaces PR #62 Before merging to the master, the code has to be tested. Once everything works as expected this branch will be merged to the master.

uvchik commented 8 years ago

Sorry, we had some problems with the code and reverted the merge on the master. We will use the branch https://github.com/UdK-VPT/Open_eQuarter/tree/oeqlib for testing and re-add your code later.

@thorade, what kind of problems do have with my PR. Could you post the error message and could you write a non-working test. I would like to solve the problems but I do not know how to test them because the code works fine for me.

thorade commented 8 years ago

I do not work on Open_eQuarter, I just helped with creating the new oeqlib branch and merging your code into that branch. @MaxUdk or @firstdayofjune would have to review the code (and they are assigned for this PR). With your code, the QGis pluign did no longer work as expected on Max computer (imac with OSX), if i remember correctly.

uvchik commented 8 years ago

The problem is that the data series of the correlations are hard-coded, otherwise I could use my own code base and just refer to the data sets. @MaxUdk, @firstdayofjune, could you send me the error message or a non-working test to fix the code together. I could also extract the correlations but I do not want to host your data in my profile (even though it is open source) because I think it should be related to your working group. Furthermore I think it is better to have one place for basic data like this in case a data error is found or an update is provided.