UdacityAndroidDevScholarship / blood-donation

This application is a collaborative project made by the Google Udacity Android Developer Scholars.

81 stars 123 forks source link

Donor and Receiver details shown on click on marker on map related to… #108

Closed omi90 closed 6 years ago

omi90 commented 6 years ago

… Issue no #103 and #104

Fill out the following while publishing a new pull request.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Enhancement
What is the current behavior? (You can also link to an open issue here) Initially there was no details shown of the donors or requestors when user clicks on a marker on map.
What is the new behavior (if this is a feature change)? On Clicking on marker on map Name , Blood Group, Purpose and clickable Phone number will be displayed in bottom sheet.

omi90 commented 6 years ago

KamalMrock commented 6 years ago

@omi90 That's a fantastic job.

KamalMrock commented 6 years ago

What if we add Route option at the place of phone number By clicking on Route Google map should open and show route between donor and receiver.

omi90 commented 6 years ago

@KamalMrock added a Get Direction button.

KamalMrock commented 6 years ago

Great.

KamalMrock commented 6 years ago

@omi90 there is no get direction button for Donor sheet. Add this to ASAP Send pr to master now.

omi90 commented 6 years ago

@KamalMrock Already added.

KamalMrock commented 6 years ago

And one thing more @omi90 Replace phone no. With call button.

I mean "Call" button instead of this +918586856857

And put "Get Direction button little lower. ASAP.

omi90 commented 6 years ago

Sure @KamalMrock will do it ASAP.

KamalMrock commented 6 years ago

@omi90 any update?