UdacityAndroidDevScholarship / blood-donation

This application is a collaborative project made by the Google Udacity Android Developer Scholars.
81 stars 122 forks source link

Keyboard overlaps I AM IN button on login/signup page #71

Closed shahidcodes closed 6 years ago

shahidcodes commented 6 years ago

Bug Report

Environment

Bug:

Steps to reproduce:

  1. Clear data if logged in
  2. Enter phone number on sign up screen
  3. Watch the keyboard covering the button ...

    • What should be the behaviour from your point of view? How do you expect the service to work? The whole UI should move up show the I AM IN button
tavishjain commented 6 years ago

@shahidcodes we would have to change the layout file for that. Or have you planned something else?

xsahil03x commented 6 years ago

@shahidcodes (Resolved + PR sent) 😄

ritesh-singh commented 6 years ago

Great..!!

shahidcodes commented 6 years ago

It still covers up the button. @xsahil03x could have used adjustResize instead of adjustPan in android:windowSoftInputMode. ss

should be something like this but without resizing the bg

ritesh-singh commented 6 years ago

@xsahil03x Had you checked, if the issue was resolved, before creating a PR for the same?

xsahil03x commented 6 years ago

@shahidcodes I checked everywhere and it's not possible to do this without resizing the whole layout.

ritesh-singh commented 6 years ago

@xsahil03x Yes, layout had to be changed.

xsahil03x commented 6 years ago

@ritesh-singh this is possible : https://camo.githubusercontent.com/3be6d81df51dbef73f8adba76111a00974117dc1/68747470733a2f2f692e696d6775722e636f6d2f734549356668392e6a7067

But in this the background is resized to create space for keyboard.

ritesh-singh commented 6 years ago

okay, @KamalMrock ??

KamalMrock commented 6 years ago

We will resolve this issue later. Leave it for now.